Merge pull request #5719 from Textualize/notification-markup

Use Textual markup for notifications

Author: willmcgugan

CHANGELOG.md

@@ -17,10 +17,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Collapsible title now accepts str, Text, or Content https://github.com/Textualize/textual/pull/5697
 - Rich Text objects will be converted to Content in OptionList and other widgets https://github.com/Textualize/textual/pull/5712
 - Textual will always convert dim attributes to RGB by default https://github.com/Textualize/textual/pull/5715
+- Notifications will now use Textual markup (previously they used Console markup) https://github.com/Textualize/textual/pull/5719
 
 ### Added
 
 - Added `TEXTUAL_DIM_FACTOR` env var to set the opacity of the 'dim' ANSI attribute https://github.com/Textualize/textual/pull/5715
+- `notify()` now accepts a `markup` parameter to disable rendering the message as markup https://github.com/Textualize/textual/pull/5719
 
 ## [3.0.1] - 2025-04-01
 
@@ -35,7 +37,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Breaking change: `App.query` and friends will now always query the default (first) screen, not necessarily the active screen.
 - Content now has a default argument of an empty string, so `Content()` is equivalent to `Content("")`
 - Assigned names to Textual-specific threads: `textual-input`, `textual-output`. These should become visible in monitoring tools (ps, top, htop) as of Python 3.14. https://github.com/Textualize/textual/pull/5654
-- Tabs now accept Content or content markup https://github.com/Textualize/textual/pull/5657
+- Tabs now accept Content or Textual markup https://github.com/Textualize/textual/pull/5657
 - Buttons will now use Textual markup rather than console markup
 - tree-sitter languages are now loaded lazily, improving cold-start time https://github.com/Textualize/textual/pull/563
 
@@ -122,7 +124,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 ### Fixed
 
-- Fixed escape tags in Content markup https://github.com/Textualize/textual/pull/5536
+- Fixed escape tags in Textual markup https://github.com/Textualize/textual/pull/5536
 
 ## [2.0.0] - 2025-02-16
 

src/textual/app.py

@@ -4285,6 +4285,7 @@ def notify(
         title: str = "",
         severity: SeverityLevel = "information",
         timeout: float | None = None,
+        markup: bool = True,
     ) -> None:
         """Create a notification.
 
@@ -4298,6 +4299,7 @@ def notify(
             title: The title for the notification.
             severity: The severity of the notification.
             timeout: The timeout (in seconds) for the notification, or `None` for default.
+            markup: Render the message as Textual markup?
 
         The `notify` method is used to create an application-wide
         notification, shown in a [`Toast`][textual.widgets._toast.Toast],
@@ -4334,7 +4336,7 @@ def notify(
         """
         if timeout is None:
             timeout = self.NOTIFICATION_TIMEOUT
-        notification = Notification(message, title, severity, timeout)
+        notification = Notification(message, title, severity, timeout, markup=markup)
         self.post_message(Notify(notification))
 
     def _on_notify(self, event: Notify) -> None:

src/textual/content.py

@@ -145,7 +145,7 @@ def __str__(self) -> str:
 
     @cached_property
     def markup(self) -> str:
-        """Get Content markup to render this Text.
+        """Get Textual markup to render this Text.
 
         Returns:
             str: A string potentially creating markup tags.

src/textual/layout.py

@@ -262,13 +262,11 @@ def get_content_height(
             ):
                 # An exception for containers with all dynamic height widgets
                 arrangement = widget._arrange(Size(width, container.height))
-                return arrangement.total_region.bottom
             else:
                 arrangement = widget._arrange(Size(width, 0))
-            height = arrangement.total_region.bottom
+            height = arrangement.total_region.height
         else:
             height = 0
-
         return height
 
     def render_keyline(self, container: Widget) -> StripRenderable:

src/textual/notifications.py

@@ -39,6 +39,9 @@ class Notification:
     timeout: float = 5
     """The timeout (in seconds) for the notification."""
 
+    markup: bool = False
+    """Render the notification message as Textual Markup?"""
+
     raised_at: float = field(default_factory=time)
     """The time when the notification was raised (in Unix time)."""
 

src/textual/widget.py

@@ -4564,6 +4564,7 @@ def notify(
         title: str = "",
         severity: SeverityLevel = "information",
         timeout: float | None = None,
+        markup: bool = True,
     ) -> None:
         """Create a notification.
 
@@ -4576,6 +4577,7 @@ def notify(
             title: The title for the notification.
             severity: The severity of the notification.
             timeout: The timeout (in seconds) for the notification, or `None` for default.
+            markup: Render the message as Textual markup?
 
         See [`App.notify`][textual.app.App.notify] for the full
         documentation for this method.
@@ -4585,16 +4587,27 @@ def notify(
                 message,
                 title=title,
                 severity=severity,
+                markup=markup,
             )
         else:
             return self.app.notify(
                 message,
                 title=title,
                 severity=severity,
                 timeout=timeout,
+                markup=markup,
             )
 
     def action_notify(
-        self, message: str, title: str = "", severity: str = "information"
+        self,
+        message: str,
+        title: str = "",
+        severity: str = "information",
+        markup: bool = True,
     ) -> None:
-        self.notify(message, title=title, severity=severity)
+        self.notify(
+            message,
+            title=title,
+            severity=severity,
+            markup=markup,
+        )

src/textual/widgets/_toast.py

@@ -4,14 +4,13 @@
 
 from typing import TYPE_CHECKING, ClassVar
 
-from rich.text import Text
-
 from textual import on
 
 if TYPE_CHECKING:
-    from textual.app import RenderResult
+    pass
 
 from textual.containers import Container
+from textual.content import Content
 from textual.css.query import NoMatches
 from textual.events import Click, Mount
 from textual.notifications import Notification, Notifications
@@ -30,7 +29,7 @@ class ToastHolder(Container, inherit_css=False):
         align-horizontal: right;
         width: 1fr;
         height: auto;
-        visibility: hidden;
+        visibility: hidden;        
     }
     """
 
@@ -43,8 +42,8 @@ class Toast(Static, inherit_css=False):
         width: 60;
         max-width: 50%;
         height: auto;
-        visibility: visible;
         margin-top: 1;
+        visibility: visible;        
         padding: 1 1;
         background: $panel-lighten-1;
         link-background: initial;
@@ -104,25 +103,27 @@ def __init__(self, notification: Notification) -> None:
         self._notification = notification
         self._timeout = notification.time_left
 
-    def render(self) -> RenderResult:
+    def render(self) -> Content:
         """Render the toast's content.
 
         Returns:
             A Rich renderable for the title and content of the Toast.
         """
         notification = self._notification
+
+        message_content = (
+            Content.from_markup(notification.message)
+            if notification.markup
+            else Content(notification.message)
+        )
+
         if notification.title:
-            header_style = self.get_component_rich_style("toast--title")
-            notification_text = Text.assemble(
-                (notification.title, header_style),
-                "\n",
-                Text.from_markup(notification.message),
-            )
-        else:
-            notification_text = Text.assemble(
-                Text.from_markup(notification.message),
+            header_style = self.get_visual_style("toast--title")
+            message_content = Content.assemble(
+                (notification.title, header_style), "\n", message_content
             )
-        return notification_text
+
+        return message_content
 
     def _on_mount(self, _: Mount) -> None:
         """Set the time running once the toast is mounted."""
@@ -155,7 +156,7 @@ class ToastRack(Container, inherit_css=False):
         visibility: hidden;
         layout: vertical;
         overflow-y: scroll;
-        margin-bottom: 1;
+        margin-bottom: 1;         
     }
     """
     DEFAULT_CLASSES = "-textual-system"