Merge branch 'main' of github.com:Textualize/textual

Author: darrenburns

CHANGELOG.md

@@ -17,14 +17,19 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 - Change default quit key to `ctrl+q` https://github.com/Textualize/textual/pull/5352
 - Changed delete line binding on TextArea to use `ctrl+shift+x` https://github.com/Textualize/textual/pull/5352
+- The command palette will now select the top item automatically https://github.com/Textualize/textual/pull/5361
 
-## [0.89.1] - 2024-11-05
+### Fixed
+
+- Fixed issue with alignment in auto containers https://github.com/Textualize/textual/pull/5360
+
+## [0.89.1] - 2024-12-05
 
 ### Fixed
 
 - Fixed alignment of docked widgets https://github.com/Textualize/textual/pull/5347
 
-## [0.89.0] - 2024-11-05
+## [0.89.0] - 2024-12-05
 
 ## Added
 

docs/widgets/data_table.md

@@ -77,8 +77,6 @@ and the [`hover_coordinate`][textual.widgets.DataTable.hover_coordinate] reactiv
 then emits the [`CellHighlighted`][textual.widgets.DataTable.CellHighlighted] and  [`CellSelected`][textual.widgets.DataTable.CellSelected]
 events. 
 
-A new table starts with no cell highlighted, i.e., row and column are zero.  You can force the first item to highlight with `move_cursor(row=1, column=1)`.  All row and column indexes start at one.
-
 === "Column Cursor"
 
     ```{.textual path="docs/examples/widgets/data_table_cursors.py"}

src/textual/command.py

@@ -20,6 +20,7 @@
 from dataclasses import dataclass
 from functools import total_ordering
 from inspect import isclass
+from operator import attrgetter
 from time import monotonic
 from typing import (
     TYPE_CHECKING,
@@ -455,9 +456,9 @@ class CommandList(OptionList, can_focus=False):
     }
 
     CommandList > .option-list--option-highlighted {
-        color: $block-cursor-foreground;
-        background: $block-cursor-background;
-        text-style: $block-cursor-text-style;
+        color: $block-cursor-blurred-foreground;
+        background: $block-cursor-blurred-background;
+        text-style: $block-cursor-blurred-text-style;
     }
 
     CommandList:nocolor > .option-list--option-highlighted {       
@@ -1014,26 +1015,12 @@ def _refresh_command_list(
             commands: The commands to show in the widget.
             clear_current: Should the current content of the list be cleared first?
         """
-        # For the moment, this is a fairly naive approach to populating the
-        # command list with a list of commands. Every time we add a
-        # new one we're nuking the list of options and populating them
-        # again. If this turns out to not be a great approach, we may try
-        # and get a lot smarter with this (ideally OptionList will grow a
-        # method to sort its content in an efficient way; but for now we'll
-        # go with "worse is better" wisdom).
-        highlighted = (
-            command_list.get_option_at_index(command_list.highlighted)
-            if command_list.highlighted is not None and not clear_current
-            else None
-        )
-
-        def sort_key(command: Command) -> float:
-            return -command.hit.score
 
-        sorted_commands = sorted(commands, key=sort_key)
+        sorted_commands = sorted(commands, key=attrgetter("hit.score"), reverse=True)
         command_list.clear_options().add_options(sorted_commands)
-        if highlighted is not None and highlighted.id:
-            command_list.highlighted = command_list.get_option_index(highlighted.id)
+
+        if sorted_commands:
+            command_list.highlighted = 0
 
         self._list_visible = bool(command_list.option_count)
         self._hit_count = command_list.option_count

src/textual/layout.py

@@ -256,22 +256,11 @@ def get_content_height(
         Returns:
             Content height (in lines).
         """
-        if not widget._nodes:
-            height = 0
-        else:
-            # Use a height of zero to ignore relative heights
-            styles_height = widget.styles.height
-            if widget._parent and len(widget._nodes) == 1:
-                # If it is an only child with height auto we want it to expand
-                height = (
-                    container.height
-                    if styles_height is not None and styles_height.is_auto
-                    else 0
-                )
-            else:
-                height = 0
-            arrangement = widget._arrange(Size(width, height))
+        if widget._nodes:
+            arrangement = widget._arrange(Size(width, 0))
             height = arrangement.total_region.bottom
+        else:
+            height = 0
 
         return height
 

src/textual/timer.py

@@ -85,12 +85,7 @@ def _start(self) -> None:
         self._task = create_task(self._run_timer(), name=self.name)
 
     def stop(self) -> None:
-        """Stop the timer.
-
-        Returns:
-            A Task object. Await this to wait until the timer has completed.
-
-        """
+        """Stop the timer."""
         if self._task is None:
             return
 

tests/command_palette/test_interaction.py

@@ -19,13 +19,13 @@ def on_mount(self) -> None:
 
 
 async def test_initial_list_no_highlight() -> None:
-    """When the list initially appears, nothing will be highlighted."""
+    """When the list initially appears, the first item is highlghted."""
     async with CommandPaletteApp().run_test() as pilot:
         assert CommandPalette.is_open(pilot.app)
         assert pilot.app.screen.query_one(CommandList).visible is False
         await pilot.press("a")
         assert pilot.app.screen.query_one(CommandList).visible is True
-        assert pilot.app.screen.query_one(CommandList).highlighted is None
+        assert pilot.app.screen.query_one(CommandList).highlighted == 0
 
 
 async def test_down_arrow_selects_an_item() -> None:
@@ -35,32 +35,19 @@ async def test_down_arrow_selects_an_item() -> None:
         assert pilot.app.screen.query_one(CommandList).visible is False
         await pilot.press("a")
         assert pilot.app.screen.query_one(CommandList).visible is True
-        assert pilot.app.screen.query_one(CommandList).highlighted is None
+        assert pilot.app.screen.query_one(CommandList).highlighted == 0
         await pilot.press("down")
-        assert pilot.app.screen.query_one(CommandList).highlighted is not None
+        assert pilot.app.screen.query_one(CommandList).highlighted == 1
 
 
 async def test_enter_selects_an_item() -> None:
-    """Typing in a search value then pressing enter should select a command."""
+    """Typing in a search value then pressing enter should dismiss the command palette."""
     async with CommandPaletteApp().run_test() as pilot:
         assert CommandPalette.is_open(pilot.app)
         assert pilot.app.screen.query_one(CommandList).visible is False
         await pilot.press("a")
         assert pilot.app.screen.query_one(CommandList).visible is True
-        assert pilot.app.screen.query_one(CommandList).highlighted is None
-        await pilot.press("enter")
-        assert pilot.app.screen.query_one(CommandList).highlighted is not None
-
-
-async def test_selection_of_command_closes_command_palette() -> None:
-    """Selecting a command from the list should close the list."""
-    async with CommandPaletteApp().run_test() as pilot:
-        assert CommandPalette.is_open(pilot.app)
-        assert pilot.app.screen.query_one(CommandList).visible is False
-        await pilot.press("a")
-        assert pilot.app.screen.query_one(CommandList).visible is True
-        assert pilot.app.screen.query_one(CommandList).highlighted is None
-        await pilot.press("enter")
-        assert pilot.app.screen.query_one(CommandList).highlighted is not None
+        assert pilot.app.screen.query_one(CommandList).highlighted == 0
         await pilot.press("enter")
         assert not CommandPalette.is_open(pilot.app)
+        assert not pilot.app.screen.query(CommandList)