Merge pull request #5724 from Textualize/refresh-keymap-bindings

Refresh keymap bindings

Author: willmcgugan

CHANGELOG.md

@@ -119,6 +119,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 
 - Fixed OptionList.add_options exhausting iterator https://github.com/Textualize/textual/pull/5540
 - Fixed screen not refreshing after pop https://github.com/Textualize/textual/pull/5543
+- Fixed footer / key panel not updating when keymaps are applied https://github.com/Textualize/textual/pull/5724
 
 ## [2.0.1] - 2025-02-16
 

src/textual/app.py

@@ -3710,6 +3710,7 @@ def set_keymap(self, keymap: Keymap) -> None:
             keymap: A mapping of binding IDs to key strings.
         """
         self._keymap = keymap
+        self.refresh_bindings()
 
     def update_keymap(self, keymap: Keymap) -> None:
         """Update the App's keymap, merging with `keymap`.
@@ -3721,6 +3722,7 @@ def update_keymap(self, keymap: Keymap) -> None:
             keymap: A mapping of binding IDs to key strings.
         """
         self._keymap = {**self._keymap, **keymap}
+        self.refresh_bindings()
 
     def handle_bindings_clash(
         self, clashed_bindings: set[Binding], node: DOMNode

tests/test_binding.py

@@ -10,6 +10,7 @@
     InvalidBinding,
     NoBinding,
 )
+from textual.screen import Screen
 
 BINDING1 = Binding("a,b", action="action1", description="description1")
 BINDING2 = Binding("c", action="action2", description="description2")
@@ -102,3 +103,27 @@ class BrokenApp(App):
 
         class BrokenApp(App):
             BINDINGS = [(", ,", "foo", "Broken")]
+
+
+async def test_keymap_update() -> None:
+    """Check that when keymaps are updated, the bindings_updated signal is sent."""
+
+    bindings_updated: list[Screen] = []
+
+    class KeymapApp(App):
+        BINDINGS = [Binding("q", "quit", "Quit", id="quit")]
+
+    def signal_bindings_updated(screen: Screen) -> None:
+        bindings_updated.append(screen)
+
+    app = KeymapApp()
+    async with app.run_test() as pilot:
+        await pilot.pause()
+        app.screen.bindings_updated_signal.subscribe(app, signal_bindings_updated)
+        assert not bindings_updated
+        app.set_keymap({"quit": "f1"})
+        await pilot.pause()
+        assert bindings_updated == [app.screen]
+        app.set_keymap({"quit": "f1"})
+        await pilot.pause()
+        assert bindings_updated == [app.screen, app.screen]