Merge branch 'main' into fix-scrollbar-fix-scrollbar-background-opacity

Author: TomJGooding

CHANGELOG.md

@@ -43,6 +43,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Fixed `Pilot.click` not working with `times` parameter https://github.com/Textualize/textual/pull/5398
 - Fixed select refocusing itself too late https://github.com/Textualize/textual/pull/5420
 - Fixed Log widget not refreshing on resize https://github.com/Textualize/textual/pull/5460
+- Fixed special case with calculating the height of a container where all children have dynamic heights https://github.com/Textualize/textual/pull/5463
 - Fixed scrollbars ignoring background opacity https://github.com/Textualize/textual/issues/5458
 
 

src/textual/layout.py

@@ -257,7 +257,15 @@ def get_content_height(
             Content height (in lines).
         """
         if widget._nodes:
-            arrangement = widget._arrange(Size(width, 0))
+            if not widget.styles.is_docked and all(
+                child.styles.is_dynamic_height for child in widget.displayed_children
+            ):
+                # An exception for containers with all dynamic height widgets
+                arrangement = widget._arrange(
+                    Size(width, container.height - widget.gutter.height)
+                )
+            else:
+                arrangement = widget._arrange(Size(width, 0))
             height = arrangement.total_region.bottom
         else:
             height = 0

src/textual/layouts/grid.py

@@ -28,7 +28,9 @@ def arrange(
         parent.pre_layout(self)
         styles = parent.styles
         row_scalars = styles.grid_rows or (
-            [Scalar.parse("1fr")] if size.height else [Scalar.parse("auto")]
+            [Scalar.parse("1fr")]
+            if (size.height and not parent.styles.is_auto_height)
+            else [Scalar.parse("auto")]
         )
         column_scalars = styles.grid_columns or [Scalar.parse("1fr")]
         gutter_horizontal = styles.grid_gutter_horizontal