Merge pull request #5340 from Textualize/input-selection

Input selection

Author: willmcgugan

CHANGELOG.md

@@ -18,6 +18,18 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Added "tab" border style https://github.com/Textualize/textual/pull/5335
 - Added support for XML syntax highlighting https://github.com/Textualize/textual/pull/5320
 - Added `TextArea.update_highlight_query` https://github.com/Textualize/textual/pull/5320
+- `Input` widget now supports text selection via mouse and keyboard https://github.com/Textualize/textual/pull/5340
+- Added new keybinds (hold shift) for text selection in `Input` https://github.com/Textualize/textual/pull/5340
+- Added `Input.selection` reactive attribute for reading and updating the current selection https://github.com/Textualize/textual/pull/5340
+- Added `Input.select_on_focus` (default `True`) to enable/disable selecting all text in an `Input` on focus https://github.com/Textualize/textual/pull/5340
+- Added methods `Input.replace`, `Input.insert`, `Input.delete`, `Input.delete_selection` for editing text https://github.com/Textualize/textual/pull/5340
+- Added `Input.selected_text` property for getting the currently selected text https://github.com/Textualize/textual/pull/5340
+- `Input` can now be scrolled independently of cursor position (hold shift and scroll with the mouse wheel in supported environments) https://github.com/Textualize/textual/pull/5340
+
+## Changed
+
+- Breaking change: Removed `Input` reactive attributes `view_position`, `cursor_position` (now exists as a property which proxies to the `Input.selection` reactive attribute), https://github.com/Textualize/textual/pull/5340
+- `Input.restrict` now checked on all edit operations (rather than just on `insert`) https://github.com/Textualize/textual/pull/5340
 
 ## Fixed
 

docs/guide/design.md

@@ -276,7 +276,6 @@ Here's a comprehensive list of these variables, their purposes, and default valu
 | `$input-cursor-foreground` | Text color of the input cursor | `$background` |
 | `$input-cursor-text-style` | Text style of the input cursor | `"none"` |
 | `$input-selection-background` | Background color of selected text | `$primary-lighten-1` with 40% opacity |
-| `$input-selection-foreground` | Text color of selected text | `$background` |
 
 ### Scrollbar
 

src/textual/design.py

@@ -321,9 +321,6 @@ def luminosity_range(spread: float) -> Iterable[tuple[str, float]]:
             "input-selection-background",
             Color.parse(colors["primary-lighten-1"]).with_alpha(0.4).hex,
         )
-        colors["input-selection-foreground"] = get(
-            "input-selection-foreground", background.hex
-        )
 
         # Markdown header styles
         colors["markdown-h1-color"] = get("markdown-h1-color", primary.hex)

src/textual/theme.py

@@ -171,7 +171,6 @@ def to_color_system(self) -> ColorSystem:
             "block-cursor-text-style": "b",
             "block-cursor-blurred-text-style": "i",
             "input-selection-background": "ansi_blue",
-            "input-selection-foreground": "ansi_white",
             "input-cursor-text-style": "reverse",
             "scrollbar": "ansi_blue",
             "border-blurred": "ansi_blue",