Merge pull request #126 from willmcgugan/win-tables

fix for tables in Jupyter on Windows

Author: willmcgugan

CHANGELOG.md

@@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [2.3.1] - 2020-06-26
+
+### Fixed
+
+- Disabled legacy_windows if jupyter is detected
+
 ## [2.3.0] - 2020-06-26
 
 ### Fixed

examples/table.py

@@ -3,7 +3,6 @@
 """
 
 from rich.console import Console
-from rich.measure import Measurement
 from rich.table import Table
 
 table = Table(title="Star Wars Movies")

pyproject.toml

@@ -2,7 +2,7 @@
 name = "rich"
 homepage = "https://github.com/willmcgugan/rich"
 documentation = "https://rich.readthedocs.io/en/latest/"
-version = "2.3.0"
+version = "2.3.1"
 description = "Render rich text, tables, progress bars, syntax highlighting, markdown and more to the terminal"
 authors = ["Will McGugan <willmcgugan@gmail.com>"]
 license = "MIT"

rich/console.py

@@ -315,7 +315,9 @@ def __init__(
         self._emoji = emoji
         self._highlight = highlight
         self.legacy_windows: bool = (
-            detect_legacy_windows() if legacy_windows is None else legacy_windows
+            (detect_legacy_windows() and not self.is_jupyter)
+            if legacy_windows is None
+            else legacy_windows
         )
 
         self._color_system: Optional[ColorSystem]

rich/table.py

@@ -552,7 +552,7 @@ def _render(
                     _Segment(_box.head_vertical, border_style),
                 ),
                 (
-                    Segment(_box.foot_left, border_style),
+                    _Segment(_box.foot_left, border_style),
                     _Segment(_box.foot_right, border_style),
                     _Segment(_box.foot_vertical, border_style),
                 ),