Merge pull request #3359 from KaiSforza/addspinnername

willmcgugan · web-flow · commit ee46ccd301c3 · 2024-09-30T15:18:33.000+01:00
Adds a `name` attribute to `Spinner`
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -68,6 +68,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 - Updated the widths of some characters https://github.com/Textualize/rich/pull/3289
 
+### Added
+
+- Included a `name` attribute to the `Spinner` class https://github.com/Textualize/rich/pull/3359
+
 ## [13.7.0] - 2023-11-15
 
 ### Added
diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md
@@ -20,6 +20,7 @@ The following people have contributed to the development of Rich:
 - [Aryaz Eghbali](https://github.com/AryazE)
 - [Oleksis Fraga](https://github.com/oleksis)
 - [Andy Gimblett](https://github.com/gimbo)
+- [Kai Giokas](https://github.com/kaisforza)
 - [Tom Gooding](https://github.com/TomJGooding)
 - [Michał Górny](https://github.com/mgorny)
 - [Nok Lam Chan](https://github.com/noklam)
diff --git a/rich/spinner.py b/rich/spinner.py
@@ -38,6 +38,7 @@ def __init__(
         self.text: "Union[RenderableType, Text]" = (
             Text.from_markup(text) if isinstance(text, str) else text
         )
+        self.name = name
         self.frames = cast(List[str], spinner["frames"])[:]
         self.interval = cast(float, spinner["interval"])
         self.start_time: Optional[float] = None

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,7 @@ def __init__(`
`38`	`38`	`self.text: "Union[RenderableType, Text]" = (`
`39`	`39`	`Text.from_markup(text) if isinstance(text, str) else text`
`40`	`40`	`)`
	`41`	`+ self.name = name`
`41`	`42`	`self.frames = cast(List[str], spinner["frames"])[:]`
`42`	`43`	`self.interval = cast(float, spinner["interval"])`
`43`	`44`	`self.start_time: Optional[float] = None`