Merge pull request #3420 from TomJGooding/fix-console-fix-selective-enabling-of-highlighting

willmcgugan · web-flow · commit 7eaaa66c2be5 · 2024-08-26T10:22:47.000+01:00
fix(console): fix selective enabling of highlighting
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -17,6 +17,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Progress track thread is now a daemon thread https://github.com/Textualize/rich/pull/3402
 - Fixed cached hash preservation upon clearing meta and links https://github.com/Textualize/rich/issues/2942
 - Fixed overriding the `background_color` of `Syntax` not including padding https://github.com/Textualize/rich/issues/3295
+- Fixed selective enabling of highlighting when disabled in the `Console` https://github.com/Textualize/rich/issues/3419
 
 ### Changed
 
diff --git a/rich/console.py b/rich/console.py
@@ -1535,7 +1535,11 @@ def check_text() -> None:
             if isinstance(renderable, str):
                 append_text(
                     self.render_str(
-                        renderable, emoji=emoji, markup=markup, highlighter=_highlighter
+                        renderable,
+                        emoji=emoji,
+                        markup=markup,
+                        highlight=highlight,
+                        highlighter=_highlighter,
                     )
                 )
             elif isinstance(renderable, Text):

Original file line number	Diff line number	Diff line change
`@@ -1535,7 +1535,11 @@ def check_text() -> None:`
`1535`	`1535`	`if isinstance(renderable, str):`
`1536`	`1536`	`append_text(`
`1537`	`1537`	`self.render_str(`
`1538`		`- renderable, emoji=emoji, markup=markup, highlighter=_highlighter`
	`1538`	`+ renderable,`
	`1539`	`+ emoji=emoji,`
	`1540`	`+ markup=markup,`
	`1541`	`+ highlight=highlight,`
	`1542`	`+ highlighter=_highlighter,`
`1539`	`1543`	`)`
`1540`	`1544`	`)`
`1541`	`1545`	`elif isinstance(renderable, Text):`