Skip to content

Commit 8cb68bc

Browse files
authored
Release 1.1.1
* Fixed problem with multiple devices and how blue temproary rectangle disappeared.
1 parent da5a9da commit 8cb68bc

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

src/Testura.Android.PageObjectCreator/Properties/AssemblyInfo.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,5 +39,5 @@
3939
// You can specify all the values or you can default the Build and Revision Numbers
4040
// by using the '*' as shown below:
4141
// [assembly: AssemblyVersion("1.0.*")]
42-
[assembly: AssemblyVersion("1.1.0.0")]
43-
[assembly: AssemblyFileVersion("1.1.0.0")]
42+
[assembly: AssemblyVersion("1.1.1.0")]
43+
[assembly: AssemblyFileVersion("1.1.1.0")]

src/Testura.Android.PageObjectCreator/Services/DumpService.cs

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public async Task<AndroidDumpInfo> DumpScreenAsync(string serial)
4242
{
4343
var dump = DumpScreen(serial);
4444
var screenshot = TakeScreenshot(serial);
45-
var packageAndActivity = GetCurrentFocus().Split('/');
45+
var packageAndActivity = GetCurrentFocus(serial).Split('/');
4646
return new AndroidDumpInfo
4747
{
4848
DumpPath = dump,
@@ -111,24 +111,22 @@ private void TraverseElement(XElement element, Node node)
111111
private string DumpScreen(string serial)
112112
{
113113
var savePath = Path.Combine(AssemblyDirectory, "dump.xml");
114-
_terminal.ExecuteCmdCommand("adb.exe", "shell", "uiautomator", "dump", "/sdcard/dump.xml");
115-
_terminal.ExecuteCmdCommand("adb.exe", "pull", "/sdcard/dump.xml", AssemblyDirectory);
116-
_terminal.ExecuteCmdCommand("adb.exe", "shell", "rm", savePath);
114+
_terminal.ExecuteCmdCommand("adb.exe", "-s", serial, "shell", "uiautomator", "dump", "/sdcard/dump.xml");
115+
_terminal.ExecuteCmdCommand("adb.exe", "-s", serial, "pull", "/sdcard/dump.xml", AssemblyDirectory);
117116
return savePath;
118117
}
119118

120119
private string TakeScreenshot(string serial)
121120
{
122121
var savePath = Path.Combine(AssemblyDirectory, "screenshot.png");
123-
_terminal.ExecuteCmdCommand("adb.exe", "shell", "screencap ", "-p", "/sdcard/screenshot.png");
124-
_terminal.ExecuteCmdCommand("adb.exe", "pull", "/sdcard/screenshot.png", AssemblyDirectory);
125-
_terminal.ExecuteCmdCommand("adb.exe", "shell", "rm", savePath);
122+
_terminal.ExecuteCmdCommand("adb.exe", "-s", serial, "shell", "screencap ", "-p", "/sdcard/screenshot.png");
123+
_terminal.ExecuteCmdCommand("adb.exe", "-s", serial, "pull", "/sdcard/screenshot.png", AssemblyDirectory);
126124
return savePath;
127125
}
128126

129-
private string GetCurrentFocus()
127+
private string GetCurrentFocus(string serial)
130128
{
131-
var result = _terminal.ExecuteCmdCommand("adb.exe", "shell", "dumpsys window windows | grep -E 'mCurrentFocus|mFocusedApp'");
129+
var result = _terminal.ExecuteCmdCommand("adb.exe", "-s", serial, "shell", "dumpsys window windows | grep -E 'mCurrentFocus|mFocusedApp'");
132130
var focus = result.Split(new[] { "\r\n" }, StringSplitOptions.RemoveEmptyEntries).First();
133131
return focus.Split(' ', '}')[4];
134132
}

src/Testura.Android.PageObjectCreator/Views/ScreenView.xaml.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ private void DeviceCanvas_OnMouseMove(object sender, MouseEventArgs e)
9292
return;
9393
}
9494

95-
if (_lastSelectedNodeRectangle != null)
95+
if (_lastSelectedNodeRectangle != null && _lastSelectedNodeRectangle != _lastTemporaryHierarchyNode)
9696
{
9797
DeviceCanvas.Children.Remove(_lastSelectedNodeRectangle);
9898
}

0 commit comments

Comments
 (0)