Skip to content

Commit 104ca8b

Browse files
committed
opt
1 parent 287f6ef commit 104ca8b

File tree

2 files changed

+7
-5
lines changed

2 files changed

+7
-5
lines changed

backend/V8/V8Platform.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,10 @@ class MessageQueueTaskRunner : public v8::TaskRunner {
8585
}
8686
#endif
8787

88+
#if SCRIPTX_V8_VERSION_BETWEEN(7, 5, 7, 5)
89+
#error "V8 compile error test"
90+
#endif
91+
8892
bool IdleTasksEnabled() override { return false; }
8993

9094
bool NonNestableTasksEnabled() const override { return true; }

test/cmake/test_v8_compiles.sh

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,10 +68,10 @@ else
6868
if echo "$SCRIPTX_TEST_V8_JOB_SPLIT_CONFIG" | grep -q -w -E '[0-9]+\/[0-9]+'; then
6969
TOTAL=$(echo ${SCRIPTX_TEST_V8_JOB_SPLIT_CONFIG} | cut -d/ -f 2)
7070
INDEX=$(echo ${SCRIPTX_TEST_V8_JOB_SPLIT_CONFIG} | cut -d/ -f 1)
71-
COUNT=${#SUPPORTED_VERSIONS[@]}
71+
COUNT=$((${#SUPPORTED_VERSIONS[@]} - 1))
7272

7373
START=$(((COUNT * INDEX + TOTAL - 1) / TOTAL)) # upper(COUNT * INDEX / TOTAL)
74-
END=$((COUNT * (INDEX + 1) / TOTAL)) # lower(COUNT * (INDEX+1) / TOTAL)
74+
END=$((COUNT * (INDEX + 1) / TOTAL)) # lower(COUNT * (INDEX+1) / TOTAL)
7575

7676
log "split job=[$START, $END] total=$COUNT"
7777

@@ -88,7 +88,5 @@ fi
8888
log "passed versions: [" "${PASSED_VERSIONS[@]}" "]"
8989
log "failed versions: [" "${FAILED_VERSIONS[@]}" "]"
9090

91-
if [[ ${#FAILED_VERSIONS[@]} -gt 0 ]]; then
92-
exit 1
93-
fi
91+
exit "${#FAILED_VERSIONS[@]}"
9492

0 commit comments

Comments
 (0)