Use records

Author: jnm2

src/TfvcMigrator/BranchIdentity.cs

@@ -1,7 +1,7 @@
 namespace TfvcMigrator;
 
 [DebuggerDisplay("{ToString(),nq}")]
-public readonly struct BranchIdentity : IEquatable<BranchIdentity>
+public readonly record struct BranchIdentity
 {
     public BranchIdentity(int creationChangeset, string path)
     {
@@ -32,11 +32,6 @@ public override string ToString()
         return $"CS{CreationChangeset}:{Path}";
     }
 
-    public override bool Equals(object? obj)
-    {
-        return obj is BranchIdentity identity && Equals(identity);
-    }
-
     public bool Equals(BranchIdentity other)
     {
         return CreationChangeset == other.CreationChangeset
@@ -47,14 +42,4 @@ public override int GetHashCode()
     {
         return HashCode.Combine(CreationChangeset, Path.GetHashCode(StringComparison.OrdinalIgnoreCase));
     }
-
-    public static bool operator ==(BranchIdentity left, BranchIdentity right)
-    {
-        return left.Equals(right);
-    }
-
-    public static bool operator !=(BranchIdentity left, BranchIdentity right)
-    {
-        return !(left == right);
-    }
 }

src/TfvcMigrator/Operations/BranchOperation.cs

@@ -1,7 +1,7 @@
 namespace TfvcMigrator.Operations;
 
 [DebuggerDisplay("{ToString(),nq}")]
-public sealed class BranchOperation : TopologicalOperation, IEquatable<BranchOperation?>
+public sealed record BranchOperation : TopologicalOperation
 {
     public BranchOperation(BranchIdentity sourceBranch, int sourceBranchChangeset, string sourceBranchPath, BranchIdentity newBranch)
     {
@@ -27,11 +27,6 @@ public BranchOperation(BranchIdentity sourceBranch, int sourceBranchChangeset, s
 
     public override string ToString() => $"CS{Changeset}: Branch {SourceBranchPath} at CS{SourceBranchChangeset} to {NewBranch.Path}";
 
-    public override bool Equals(object? obj)
-    {
-        return Equals(obj as BranchOperation);
-    }
-
     public bool Equals(BranchOperation? other)
     {
         return other != null &&

src/TfvcMigrator/Operations/DeleteOperation.cs

@@ -1,33 +1,9 @@
 namespace TfvcMigrator.Operations;
 
 [DebuggerDisplay("{ToString(),nq}")]
-public sealed class DeleteOperation : TopologicalOperation, IEquatable<DeleteOperation?>
+public sealed record DeleteOperation(int Changeset, BranchIdentity Branch) : TopologicalOperation
 {
-    public DeleteOperation(int changeset, BranchIdentity branch)
-    {
-        Changeset = changeset;
-        Branch = branch;
-    }
-
-    public override int Changeset { get; }
-    public BranchIdentity Branch { get; }
-
-    public override bool Equals(object? obj)
-    {
-        return Equals(obj as DeleteOperation);
-    }
-
-    public bool Equals(DeleteOperation? other)
-    {
-        return other != null &&
-               Changeset == other.Changeset &&
-               Branch.Equals(other.Branch);
-    }
-
-    public override int GetHashCode()
-    {
-        return HashCode.Combine(Changeset, Branch);
-    }
+    public override int Changeset { get; } = Changeset;
 
     public override string ToString() => $"CS{Changeset}: Delete {Branch.Path}";
 }

src/TfvcMigrator/Operations/MergeOperation.cs

@@ -1,7 +1,7 @@
 namespace TfvcMigrator.Operations;
 
 [DebuggerDisplay("{ToString(),nq}")]
-public sealed class MergeOperation : TopologicalOperation, IEquatable<MergeOperation?>
+public sealed record MergeOperation : TopologicalOperation
 {
     public MergeOperation(int changeset, BranchIdentity sourceBranch, int sourceBranchChangeset, string sourceBranchPath, BranchIdentity targetBranch, string targetBranchPath)
     {
@@ -31,11 +31,6 @@ public MergeOperation(int changeset, BranchIdentity sourceBranch, int sourceBran
 
     public override string ToString() => $"CS{Changeset}: Merge {SourceBranchPath} at {SourceBranchChangeset} to {TargetBranchPath}";
 
-    public override bool Equals(object? obj)
-    {
-        return Equals(obj as MergeOperation);
-    }
-
     public bool Equals(MergeOperation? other)
     {
         return other != null &&

src/TfvcMigrator/Operations/RenameOperation.cs

@@ -1,34 +1,9 @@
 namespace TfvcMigrator.Operations;
 
 [DebuggerDisplay("{ToString(),nq}")]
-public sealed class RenameOperation : TopologicalOperation, IEquatable<RenameOperation?>
+public sealed record RenameOperation(BranchIdentity OldIdentity, BranchIdentity NewIdentity) : TopologicalOperation
 {
-    public RenameOperation(BranchIdentity oldIdentity, BranchIdentity newIdentity)
-    {
-        OldIdentity = oldIdentity;
-        NewIdentity = newIdentity;
-    }
-
     public override int Changeset => NewIdentity.CreationChangeset;
-    public BranchIdentity OldIdentity { get; }
-    public BranchIdentity NewIdentity { get; }
 
     public override string ToString() => $"CS{Changeset}: Rename {OldIdentity.Path} to {NewIdentity.Path}";
-
-    public override bool Equals(object? obj)
-    {
-        return Equals(obj as RenameOperation);
-    }
-
-    public bool Equals(RenameOperation? other)
-    {
-        return other != null &&
-               OldIdentity.Equals(other.OldIdentity) &&
-               NewIdentity.Equals(other.NewIdentity);
-    }
-
-    public override int GetHashCode()
-    {
-        return HashCode.Combine(OldIdentity, NewIdentity);
-    }
 }

src/TfvcMigrator/Operations/TopologicalOperation.cs

@@ -1,10 +1,8 @@
 namespace TfvcMigrator.Operations;
 
-public abstract class TopologicalOperation
+public abstract record TopologicalOperation
 {
     public abstract int Changeset { get; }
 
     public abstract override string ToString();
-    public abstract override bool Equals(object? obj);
-    public abstract override int GetHashCode();
 }

src/TfvcMigrator/RootPathChange.cs

@@ -1,7 +1,7 @@
 namespace TfvcMigrator;
 
 [DebuggerDisplay("{ToString(),nq}")]
-public sealed class RootPathChange : IEquatable<RootPathChange?>
+public sealed record RootPathChange
 {
     public RootPathChange(int changeset, string newSourceRootPath)
     {
@@ -18,22 +18,5 @@ public RootPathChange(int changeset, string newSourceRootPath)
     public int Changeset { get; }
     public string NewSourceRootPath { get; }
 
-    public override bool Equals(object? obj)
-    {
-        return Equals(obj as RootPathChange);
-    }
-
-    public bool Equals(RootPathChange? other)
-    {
-        return other != null &&
-               Changeset == other.Changeset &&
-               NewSourceRootPath == other.NewSourceRootPath;
-    }
-
-    public override int GetHashCode()
-    {
-        return HashCode.Combine(Changeset, NewSourceRootPath);
-    }
-
     public override string ToString() => $"CS{Changeset}:{NewSourceRootPath}";
 }