Use global usings

jnm2 · jnm2 · commit a8f2f4803b9f · 2022-01-29T14:28:31.000-05:00
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -1,11 +1,20 @@
 <Project>
 
   <PropertyGroup>
-    <TreatWarningsAsErrors Condition="'$(Configuration)' == 'Release'">true</TreatWarningsAsErrors>
+	<TreatWarningsAsErrors Condition="'$(Configuration)' == 'Release'">true</TreatWarningsAsErrors>
   </PropertyGroup>
 
   <ItemGroup>
     <PackageReference Include="StyleCop.Analyzers" Version="1.2.0-beta.406" PrivateAssets="all" />
   </ItemGroup>
 
+  <PropertyGroup>
+	<ImplicitUsings>enable</ImplicitUsings>
+  </PropertyGroup>
+  <ItemGroup>
+    <Using Include="System.Collections.Immutable" />
+    <Using Include="System.Diagnostics" />
+	<Using Include="System.Diagnostics.CodeAnalysis" />
+  </ItemGroup>
+
 </Project>
diff --git a/src/TfvcMigrator.Tests/EnumerableExtensionsTests/WithLookaheadTests.cs b/src/TfvcMigrator.Tests/EnumerableExtensionsTests/WithLookaheadTests.cs
@@ -1,9 +1,4 @@
-﻿using System;
-using System.Collections.Generic;
-using System.Threading.Tasks;
-using NSubstitute;
-using NUnit.Framework;
-using Shouldly;
+﻿using NSubstitute;
 
 namespace TfvcMigrator.Tests.EnumerableExtensionsTests
 {
diff --git a/src/TfvcMigrator.Tests/TfvcMigrator.Tests.csproj b/src/TfvcMigrator.Tests/TfvcMigrator.Tests.csproj
@@ -23,4 +23,9 @@
     <ProjectReference Include="..\TfvcMigrator\TfvcMigrator.csproj" />
   </ItemGroup>
 
+  <ItemGroup>
+    <Using Include="NUnit.Framework" />
+    <Using Include="Shouldly" />
+  </ItemGroup>
+
 </Project>
diff --git a/src/TfvcMigrator.Tests/UtilsTests/ContainsCrlfTests.cs b/src/TfvcMigrator.Tests/UtilsTests/ContainsCrlfTests.cs
@@ -1,8 +1,4 @@
-﻿using System.IO;
-using NUnit.Framework;
-using Shouldly;
-
-namespace TfvcMigrator.Tests.UtilsTests
+﻿namespace TfvcMigrator.Tests.UtilsTests
 {
     public static class ContainsCrlfTests
     {
diff --git a/src/TfvcMigrator/ArrayBuilder.cs b/src/TfvcMigrator/ArrayBuilder.cs
@@ -1,7 +1,4 @@
-﻿using System;
-using System.Diagnostics.CodeAnalysis;
-
-namespace TfvcMigrator
+﻿namespace TfvcMigrator
 {
     /// <summary>
     /// Enables building an array by setting indexes in any order without having to use an <c>Add</c> method.
diff --git a/src/TfvcMigrator/AsyncParallelQueue.AtomicOperations.cs b/src/TfvcMigrator/AsyncParallelQueue.AtomicOperations.cs
@@ -1,7 +1,4 @@
-﻿using System;
-using System.Collections;
-using System.Collections.Generic;
-using System.Threading.Tasks;
+﻿using System.Collections;
 
 namespace TfvcMigrator
 {
diff --git a/src/TfvcMigrator/AsyncParallelQueue.NextOperation.cs b/src/TfvcMigrator/AsyncParallelQueue.NextOperation.cs
@@ -1,8 +1,4 @@
-﻿using System;
-using System.Diagnostics.CodeAnalysis;
-using System.Threading.Tasks;
-
-namespace TfvcMigrator
+﻿namespace TfvcMigrator
 {
     internal sealed partial class AsyncParallelQueue<T>
     {
diff --git a/src/TfvcMigrator/AsyncParallelQueue.cs b/src/TfvcMigrator/AsyncParallelQueue.cs
@@ -1,10 +1,4 @@
-﻿using System;
-using System.Collections;
-using System.Collections.Generic;
-using System.Collections.Immutable;
-using System.Linq;
-using System.Threading;
-using System.Threading.Tasks;
+﻿using System.Collections;
 
 namespace TfvcMigrator
 {
diff --git a/src/TfvcMigrator/BranchIdentifier.cs b/src/TfvcMigrator/BranchIdentifier.cs
@@ -1,8 +1,4 @@
-﻿using System;
-using System.Collections.Generic;
-using System.Linq;
-
-namespace TfvcMigrator
+﻿namespace TfvcMigrator
 {
     public sealed class BranchIdentifier
     {
diff --git a/src/TfvcMigrator/BranchIdentity.cs b/src/TfvcMigrator/BranchIdentity.cs
@@ -1,7 +1,4 @@
-﻿using System;
-using System.Diagnostics;
-
-namespace TfvcMigrator
+﻿namespace TfvcMigrator
 {
     [DebuggerDisplay("{ToString(),nq}")]
     public readonly struct BranchIdentity : IEquatable<BranchIdentity>
diff --git a/src/TfvcMigrator/CommonUtils.cs b/src/TfvcMigrator/CommonUtils.cs
@@ -1,7 +1,4 @@
-﻿using System;
-using System.Collections;
-using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
+﻿using System.Collections;
 
 namespace TfvcMigrator
 {
diff --git a/src/TfvcMigrator/CrlfRenormalizingStream.cs b/src/TfvcMigrator/CrlfRenormalizingStream.cs
@@ -1,6 +1,4 @@
-﻿using System;
-using System.Buffers;
-using System.IO;
+﻿using System.Buffers;
 
 namespace TfvcMigrator
 {
diff --git a/src/TfvcMigrator/EnumerableExtensions.WithLookahead.cs b/src/TfvcMigrator/EnumerableExtensions.WithLookahead.cs
@@ -1,10 +1,4 @@
-﻿using System;
-using System.Collections.Generic;
-using System.Diagnostics.CodeAnalysis;
-using System.Threading;
-using System.Threading.Tasks;
-
-namespace TfvcMigrator
+﻿namespace TfvcMigrator
 {
     partial class EnumerableExtensions
     {
diff --git a/src/TfvcMigrator/EnumerableExtensions.cs b/src/TfvcMigrator/EnumerableExtensions.cs
@@ -1,11 +1,4 @@
-﻿using System;
-using System.Collections.Generic;
-using System.Collections.Immutable;
-using System.Linq;
-using System.Threading;
-using System.Threading.Tasks;
-
-namespace TfvcMigrator
+﻿namespace TfvcMigrator
 {
     public static partial class EnumerableExtensions
     {
diff --git a/src/TfvcMigrator/Operations/BranchOperation.cs b/src/TfvcMigrator/Operations/BranchOperation.cs
@@ -1,7 +1,4 @@
-﻿using System;
-using System.Diagnostics;
-
-namespace TfvcMigrator.Operations
+﻿namespace TfvcMigrator.Operations
 {
     [DebuggerDisplay("{ToString(),nq}")]
     public sealed class BranchOperation : TopologicalOperation, IEquatable<BranchOperation?>
diff --git a/src/TfvcMigrator/Operations/DeleteOperation.cs b/src/TfvcMigrator/Operations/DeleteOperation.cs
@@ -1,7 +1,4 @@
-﻿using System;
-using System.Diagnostics;
-
-namespace TfvcMigrator.Operations
+﻿namespace TfvcMigrator.Operations
 {
     [DebuggerDisplay("{ToString(),nq}")]
     public sealed class DeleteOperation : TopologicalOperation, IEquatable<DeleteOperation?>
diff --git a/src/TfvcMigrator/Operations/MergeOperation.cs b/src/TfvcMigrator/Operations/MergeOperation.cs
@@ -1,7 +1,4 @@
-﻿using System;
-using System.Diagnostics;
-
-namespace TfvcMigrator.Operations
+﻿namespace TfvcMigrator.Operations
 {
     [DebuggerDisplay("{ToString(),nq}")]
     public sealed class MergeOperation : TopologicalOperation, IEquatable<MergeOperation?>
diff --git a/src/TfvcMigrator/Operations/RenameOperation.cs b/src/TfvcMigrator/Operations/RenameOperation.cs
@@ -1,7 +1,4 @@
-﻿using System;
-using System.Diagnostics;
-
-namespace TfvcMigrator.Operations
+﻿namespace TfvcMigrator.Operations
 {
     [DebuggerDisplay("{ToString(),nq}")]
     public sealed class RenameOperation : TopologicalOperation, IEquatable<RenameOperation?>
diff --git a/src/TfvcMigrator/PathUtils.cs b/src/TfvcMigrator/PathUtils.cs
@@ -1,9 +1,4 @@
-﻿using System;
-using System.Collections.Generic;
-using System.Collections.Immutable;
-using System.Linq;
-
-namespace TfvcMigrator
+﻿namespace TfvcMigrator
 {
     internal static class PathUtils
     {
diff --git a/src/TfvcMigrator/Program.cs b/src/TfvcMigrator/Program.cs
@@ -1,13 +1,6 @@
-﻿using System;
-using System.Collections.Generic;
-using System.Collections.Immutable;
-using System.CommandLine;
+﻿using System.CommandLine;
 using System.Globalization;
-using System.IO;
-using System.Linq;
 using System.Text;
-using System.Threading;
-using System.Threading.Tasks;
 using LibGit2Sharp;
 using Microsoft.TeamFoundation.SourceControl.WebApi;
 using Microsoft.VisualStudio.Services.Common;
diff --git a/src/TfvcMigrator/ReadOnlySegmentBuilder.cs b/src/TfvcMigrator/ReadOnlySegmentBuilder.cs
@@ -1,5 +1,4 @@
-﻿using System;
-using System.Buffers;
+﻿using System.Buffers;
 
 namespace TfvcMigrator
 {
diff --git a/src/TfvcMigrator/RepositoryBranchMapping.cs b/src/TfvcMigrator/RepositoryBranchMapping.cs
@@ -1,6 +1,4 @@
-﻿using System;
-
-namespace TfvcMigrator
+﻿namespace TfvcMigrator
 {
     public readonly struct RepositoryBranchMapping
     {
diff --git a/src/TfvcMigrator/RootPathChange.cs b/src/TfvcMigrator/RootPathChange.cs
@@ -1,7 +1,4 @@
-﻿using System;
-using System.Diagnostics;
-
-namespace TfvcMigrator
+﻿namespace TfvcMigrator
 {
     [DebuggerDisplay("{ToString(),nq}")]
     public sealed class RootPathChange
diff --git a/src/TfvcMigrator/TimedProgress.cs b/src/TfvcMigrator/TimedProgress.cs
@@ -1,7 +1,4 @@
-﻿using System;
-using System.Diagnostics;
-using System.Runtime.CompilerServices;
-using System.Threading;
+﻿using System.Runtime.CompilerServices;
 
 namespace TfvcMigrator
 {
diff --git a/src/TfvcMigrator/TopologicalSortException.cs b/src/TfvcMigrator/TopologicalSortException.cs
@@ -1,6 +1,4 @@
-﻿using System;
-using System.Collections.Immutable;
-using System.Text;
+﻿using System.Text;
 
 namespace TfvcMigrator
 {
diff --git a/src/TfvcMigrator/TopologicalSortExtensions.DependentItemInfo.cs b/src/TfvcMigrator/TopologicalSortExtensions.DependentItemInfo.cs
@@ -1,6 +1,4 @@
-﻿using System.Collections.Generic;
-
-namespace TfvcMigrator
+﻿namespace TfvcMigrator
 {
     internal static partial class TopologicalSortExtensions
     {
diff --git a/src/TfvcMigrator/TopologicalSortExtensions.cs b/src/TfvcMigrator/TopologicalSortExtensions.cs
@@ -1,9 +1,4 @@
-﻿using System;
-using System.Collections.Generic;
-using System.Collections.Immutable;
-using System.Linq;
-
-namespace TfvcMigrator
+﻿namespace TfvcMigrator
 {
     internal static partial class TopologicalSortExtensions
     {
diff --git a/src/TfvcMigrator/TopologicalState.cs b/src/TfvcMigrator/TopologicalState.cs
@@ -1,5 +1,4 @@
-﻿using System.Collections.Immutable;
-using TfvcMigrator.Operations;
+﻿using TfvcMigrator.Operations;
 
 namespace TfvcMigrator
 {
diff --git a/src/TfvcMigrator/TopologyAnalyzer.cs b/src/TfvcMigrator/TopologyAnalyzer.cs
@@ -1,8 +1,4 @@
-﻿using System;
-using System.Collections.Generic;
-using System.Collections.Immutable;
-using System.Linq;
-using Microsoft.TeamFoundation.SourceControl.WebApi;
+﻿using Microsoft.TeamFoundation.SourceControl.WebApi;
 using TfvcMigrator.Operations;
 
 namespace TfvcMigrator
diff --git a/src/TfvcMigrator/Utils.cs b/src/TfvcMigrator/Utils.cs
@@ -1,7 +1,4 @@
-﻿using System;
-using System.Buffers;
-using System.IO;
-using System.Threading;
+﻿using System.Buffers;
 
 namespace TfvcMigrator
 {

Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,4 @@`
`1`		`-using System.IO;`
`2`		`-using NUnit.Framework;`
`3`		`-using Shouldly;`
`4`		`-`
`5`		`-namespace TfvcMigrator.Tests.UtilsTests`
	`1`	`+namespace TfvcMigrator.Tests.UtilsTests`
`6`	`2`	`{`
`7`	`3`	`public static class ContainsCrlfTests`
`8`	`4`	`{`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,4 @@`
`1`		`-using System;`
`2`		`-using System.Diagnostics.CodeAnalysis;`
`3`		`-`
`4`		`-namespace TfvcMigrator`
	`1`	`+namespace TfvcMigrator`
`5`	`2`	`{`
`6`	`3`	`/// <summary>`
`7`	`4`	`/// Enables building an array by setting indexes in any order without having to use an <c>Add</c> method.`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,4 @@`
`1`		`-using System;`
`2`		`-using System.Collections;`
`3`		`-using System.Collections.Generic;`
`4`		`-using System.Threading.Tasks;`
	`1`	`+using System.Collections;`
`5`	`2`
`6`	`3`	`namespace TfvcMigrator`
`7`	`4`	`{`
Original file line number	Diff line number	Diff line change
`@@ -1,7 +1,4 @@`
`1`		`-using System;`
`2`		`-using System.Diagnostics;`
`3`		`-`
`4`		`-namespace TfvcMigrator`
	`1`	`+namespace TfvcMigrator`
`5`	`2`	`{`
`6`	`3`	`[DebuggerDisplay("{ToString(),nq}")]`
`7`	`4`	`public readonly struct BranchIdentity : IEquatable<BranchIdentity>`