Skip to content

[Fixed] [BUG] JudgmentMessageCommand triggered on HoldTails #785

@DarkBahamut162

Description

@DarkBahamut162

Is there an existing issue for this?

  • I have searched the existing issues and none matched.

Operating System

Windows 10 Home 64-bit (22H2)

CPU

AMD Ryzen 5 5600

GPU

AMD Radeon RX 6600

Storage

256GB M.2 NVMe & 2+4TB WD Black HDD

Game Version

5.0.0-042

Game Mode

be-mu

Theme

ITG3Encore using simulated WIFE3 Scoring (From Etterna) [currently semi-disabled because of the bug]

Describe the problem

On each row of notes, JudgmentMessageCommand is called.
But ever since OutFox (0.)4.9.8 [since Apr 25, 2021], HoldTails call them as well.
This problem only occures whenever CountNotesSeparately() is true.
It is assumed that, during a rewrite, a check for HeadNotes went missing, counting it HoldTails.

The following recording displays this problem: https://www.youtube.com/watch?v=C5_YX2UeWAM
WIFE3 Scoring from Etterna was ported over into OutFox/ITGmania/StepMania.
[For debugging purposes, it gives the maximum scoring]
A deviation of scores happens at 1:24 and 2:03 (where a HoldTail and a normal Note are in the same row)
Just HoldTails by themselves don't trigger this bug, only if they are together with other Notes within the same row.

Describe what should happen

Either fix this loophole or revert to the check from before OutFox (0.)4.9.7 [from Feb 23, 2021].

Relevant Log output

No response

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions