Skip to content
This repository was archived by the owner on Nov 15, 2024. It is now read-only.

Commit e2949a8

Browse files
committed
session_id into properties
1 parent e7977f5 commit e2949a8

File tree

8 files changed

+9
-8
lines changed

8 files changed

+9
-8
lines changed

api_server/modules/analytics/analytics_client.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,9 @@ class AnalyticsClient {
3939
timestamp: new Date(),
4040
type: "track",
4141
anonymousId: UUID(),
42-
session_id: UUID()
4342
};
43+
data.session_id = data.session_id || UUID();
44+
4445
const nrUserId = options.user ? options.user.get('nrUserId') : options.nrUserId;
4546
if (nrUserId) {
4647
trackData.userId = nrUserId; //userId;

api_server/modules/code_errors/test/unfollow_link/tracking_test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,13 +74,13 @@ class TrackingTest extends Aggregation(CodeStreamMessageTest, CommonInit) {
7474
messageId: data.messageId || '<missing messageId>',
7575
timestamp: data.timestamp || '<missing timestamp>',
7676
anonymousId: data.anonymousId || '<missing anonymousId>',
77-
session_id: data.session_id || '<missing session_id>',
7877
type: 'track',
7978
properties: {
8079
//user_id: this.currentUser.user.nrUserId,
8180
platform: 'codestream',
8281
path: 'N/A (codestream)',
8382
section: 'N/A (codestream)',
83+
session_id: data.session_id || '<missing session_id>',
8484
meta_data_15: JSON.stringify(expectedMetaData),
8585
meta_data_14: 'change: code_error_unfollowed',
8686
meta_data_13: 'source_of_change: email_link'

api_server/modules/codemarks/test/unfollow_link/tracking_test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,13 +74,13 @@ class TrackingTest extends Aggregation(CodeStreamMessageTest, CommonInit) {
7474
messageId: data.messageId || '<missing messageId>',
7575
timestamp: data.timestamp || '<missing timestamp>',
7676
anonymousId: data.anonymousId || '<missing anonymousId>',
77-
session_id: data.session_id || '<missing session_id>',
7877
type: 'track',
7978
properties: {
8079
//user_id: this.currentUser.user.nrUserId,
8180
platform: 'codestream',
8281
path: 'N/A (codestream)',
8382
section: 'N/A (codestream)',
83+
session_id: data.session_id || '<missing session_id>',
8484
meta_data_15: JSON.stringify(expectedMetaData),
8585
meta_data_14: 'change: codemark_unfollowed',
8686
meta_data_13: 'source_of_change: email_link'

api_server/modules/inbound_emails/test/tracking_test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,13 +107,13 @@ class TrackingTest extends InboundEmailMessageTest {
107107
messageId: data.messageId || '<missing messageId>',
108108
timestamp: data.timestamp || '<missing timestamp>',
109109
anonymousId: data.anonymousId || '<missing anonymousId>',
110-
session_id: data.session_id || '<missing session_id>',
111110
type: 'track',
112111
properties: {
113112
//user_id: this.currentUser.user.nrUserId,
114113
platform: 'codestream',
115114
path: 'N/A (codestream)',
116115
section: 'N/A (codestream)',
116+
session_id: data.session_id || '<missing session_id>',
117117
meta_data_15: JSON.stringify(expectedMetaData),
118118
'Parent ID': parentId,
119119
'Parent Type': parentType,

api_server/modules/reviews/test/unfollow_link/tracking_test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,13 +74,13 @@ class TrackingTest extends Aggregation(CodeStreamMessageTest, CommonInit) {
7474
messageId: data.messageId || '<missing messageId>',
7575
timestamp: data.timestamp || '<missing timestamp>',
7676
anonymousId: data.anonymousId || '<missing anonymousId>',
77-
session_id: data.session_id || '<missing session_id>',
7877
type: 'track',
7978
properties: {
8079
//user_id: this.currentUser.user.nrUserId,
8180
platform: 'codestream',
8281
path: 'N/A (codestream)',
8382
section: 'N/A (codestream)',
83+
session_id: data.session_id || '<missing session_id>',
8484
meta_data_15: JSON.stringify(expectedMetaData),
8585
meta_data_14: 'change: review_unfollowed',
8686
meta_data_13: 'source_of_change: email_link'

api_server/modules/users/test/unsubscribe_notification/tracking_test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,13 @@ class TrackingTest extends Aggregation(CodeStreamMessageTest, CommonInit) {
6565
messageId: data.messageId || '<missing messageId>',
6666
timestamp: data.timestamp || '<missing timestamp>',
6767
anonymousId: data.anonymousId || '<missing anonymousId>',
68-
session_id: data.session_id || '<missing session_id>',
6968
type: 'track',
7069
properties: {
7170
//user_id: this.currentUser.user.nrUserId,
7271
platform: 'codestream',
7372
path: 'N/A (codestream)',
7473
section: 'N/A (codestream)',
74+
session_id: data.session_id || '<missing session_id>',
7575
meta_data_15: JSON.stringify(expectedMetaData),
7676
'meta_data': 'email_type: discussion',
7777
'event_type': 'response'

api_server/modules/users/test/unsubscribe_reminder/tracking_test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,13 +65,13 @@ class TrackingTest extends Aggregation(CodeStreamMessageTest, CommonInit) {
6565
messageId: data.messageId || '<missing messageId>',
6666
timestamp: data.timestamp || '<missing timestamp>',
6767
anonymousId: data.anonymousId || '<missing anonymousId>',
68-
session_id: data.session_id || '<missing session_id>',
6968
type: 'track',
7069
properties: {
7170
//user_id: this.currentUser.user.nrUserId,
7271
platform: 'codestream',
7372
path: 'N/A (codestream)',
7473
section: 'N/A (codestream)',
74+
session_id: data.session_id || '<missing session_id>',
7575
meta_data_15: JSON.stringify(expectedMetaData),
7676
'meta_data': 'email_type: reminder',
7777
'event_type': 'response'

api_server/modules/users/test/unsubscribe_weekly/tracking_test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,13 +69,13 @@ class TrackingTest extends Aggregation(CodeStreamMessageTest, CommonInit) {
6969
messageId: data.messageId || '<missing messageId>',
7070
timestamp: data.timestamp || '<missing timestamp>',
7171
anonymousId: data.anonymousId || '<missing anonymousId>',
72-
session_id: data.session_id || '<missing session_id>',
7372
type: 'track',
7473
properties: {
7574
//user_id: this.currentUser.user.nrUserId,
7675
platform: 'codestream',
7776
path: 'N/A (codestream)',
7877
section: 'N/A (codestream)',
78+
session_id: data.session_id || '<missing session_id>',
7979
meta_data_15: JSON.stringify(expectedMetaData),
8080
'meta_data': 'email_type: weekly_activity',
8181
'event_type': 'response'

0 commit comments

Comments
 (0)