Logger PHPStan fix

Author: TavoNiievez

src/Codeception/Module/Symfony/EventsAssertionsTrait.php

@@ -32,9 +32,7 @@ trait EventsAssertionsTrait
      */
     public function dontSeeEvent(array|string|null $expected = null): void
     {
-        $actualEvents = $this->getDispatchedEventNames();
-        $actual       = [$this->getOrphanedEvents(), $actualEvents];
-        $this->assertEventTriggered(false, $expected, $actual);
+        $this->handleEventAssertion(false, $expected, false);
     }
 
     /**
@@ -96,8 +94,7 @@ public function dontSeeEventTriggered(array|object|string $expected): void
      */
     public function dontSeeOrphanEvent(array|string|null $expected = null): void
     {
-        $actual = [$this->getOrphanedEvents()];
-        $this->assertEventTriggered(false, $expected, $actual);
+        $this->handleEventAssertion(false, $expected, true);
     }
 
     /**
@@ -112,9 +109,7 @@ public function dontSeeOrphanEvent(array|string|null $expected = null): void
      */
     public function seeEvent(array|string $expected): void
     {
-        $actualEvents = $this->getDispatchedEventNames();
-        $actual       = [$this->getOrphanedEvents(), $actualEvents];
-        $this->assertEventTriggered(true, $expected, $actual);
+        $this->handleEventAssertion(true, $expected, false);
     }
 
     /**
@@ -175,8 +170,7 @@ public function seeEventTriggered(array|object|string $expected): void
      */
     public function seeOrphanEvent(array|string $expected): void
     {
-        $actual = [$this->getOrphanedEvents()];
-        $this->assertEventTriggered(true, $expected, $actual);
+        $this->handleEventAssertion(true, $expected, true);
     }
 
     /** @return list<array{event: string, pretty: string}> */
@@ -191,16 +185,6 @@ protected function getDispatchedEvents(): array
         return $events;
     }
 
-    /** @return list<string> */
-    private function getDispatchedEventNames(): array
-    {
-        $names = [];
-        foreach ($this->getDispatchedEvents() as $listener) {
-            $names[] = $listener['event'];
-        }
-        return $names;
-    }
-
     /** @return list<string> */
     protected function getOrphanedEvents(): array
     {
@@ -213,6 +197,16 @@ protected function getOrphanedEvents(): array
         return $events;
     }
 
+    /** @param string|object|list<string|object>|null $expected */
+    private function handleEventAssertion(bool $assertTrue, array|object|string|null $expected, bool $orphanOnly): void
+    {
+        $actual = $orphanOnly
+            ? [$this->getOrphanedEvents()]
+            : [$this->getOrphanedEvents(), array_column($this->getDispatchedEvents(), 'event')];
+
+        $this->assertEventTriggered($assertTrue, $expected, $actual);
+    }
+
     /**
      * @param string|object|list<string|object>|null $expected
      * @param list<list<string>>                     $actual
@@ -257,7 +251,7 @@ protected function assertListenerCalled(
         if ($expectedEvents === []) {
             $expectedEvents = [null];
         } elseif (count($expectedListeners) > 1) {
-            Assert::fail('Cannot check multiple listeners with specific events; split assertions.');
+            Assert::fail('Cannot check for events when using multiple listeners. Make multiple assertions instead.');
         }
 
         $actualEvents = $this->getDispatchedEvents();