Skip to content

Commit df24f24

Browse files
TarekRaafatTarekRaafat
committed
v10.2.4 => Release Notes for details resolves #256 
1 parent 9fd1b16 commit df24f24

17 files changed

+25
-30
lines changed

‎README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,13 +51,13 @@ autoComplete.js is a simple, pure vanilla Javascript library progressively desig
5151
`JS`
5252

5353
```html
54-
<script src="https://cdn.jsdelivr.net/npm/@tarekraafat/autocomplete.js@10.2.2/dist/autoComplete.min.js"></script>
54+
<script src="https://cdn.jsdelivr.net/npm/@tarekraafat/autocomplete.js@10.2.4/dist/autoComplete.min.js"></script>
5555
```
5656

5757
`CSS`
5858

5959
```html
60-
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@tarekraafat/autocomplete.js@10.2.2/dist/css/autoComplete.min.css">
60+
<link rel="stylesheet" href="https://cdn.jsdelivr.net/npm/@tarekraafat/autocomplete.js@10.2.4/dist/css/autoComplete.min.css">
6161
```
6262
#### Package Manager
6363

‎dist/autoComplete.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -274,14 +274,11 @@
274274
}
275275
});
276276

277-
var getData = function getData(ctx) {
277+
var getData = function getData(ctx, query) {
278278
return new Promise(function ($return, $error) {
279-
var input, query, data;
280-
input = ctx.input;
281-
query = ctx.query;
279+
var data;
282280
data = ctx.data;
283281
if (data.cache && data.store) return $return();
284-
query = query ? query(input.value) : input.value;
285282
return new Promise(function ($return, $error) {
286283
if (typeof data.src === "function") {
287284
return data.src(query).then($return, $error);
@@ -475,7 +472,7 @@
475472
queryVal = ctx.query ? ctx.query(queryVal) : queryVal;
476473
condition = checkTrigger(queryVal, ctx.trigger, ctx.threshold);
477474
if (condition) {
478-
return getData(ctx).then(function ($await_2) {
475+
return getData(ctx, queryVal).then(function ($await_2) {
479476
try {
480477
if (ctx.feedback instanceof Error) return $return();
481478
findMatches(queryVal, ctx);

‎dist/autoComplete.js.gz

-31 Bytes
Binary file not shown.

‎dist/autoComplete.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎dist/autoComplete.min.js.gz

-15 Bytes
Binary file not shown.

‎docs/demo/index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@
7272
<meta name="msapplication-TileImage" content="/ms-icon-144x144.png">
7373
<meta name="theme-color" content="#ffffff">
7474
<link rel="stylesheet" type="text/css" media="screen"
75-
href="https://cdn.jsdelivr.net/npm/@tarekraafat/autocomplete.js@10.2.3/dist/css/autoComplete.min.css">
75+
href="https://cdn.jsdelivr.net/npm/@tarekraafat/autocomplete.js@10.2.4/dist/css/autoComplete.min.css">
7676
<!-- <link rel="stylesheet" type="text/css" media="screen" href="./css/autoComplete.css"> -->
7777
<link rel="stylesheet" type="text/css" media="screen" href="./css/main.css">
7878
<link href="https://fonts.googleapis.com/css?family=PT+Sans" rel="stylesheet">
@@ -150,7 +150,7 @@ <h4>mode</h4>
150150
</div>
151151
</footer>
152152
</div>
153-
<script src="https://cdn.jsdelivr.net/npm/@tarekraafat/autocomplete.js@10.2.3/dist/autoComplete.min.js"></script>
153+
<script src="https://cdn.jsdelivr.net/npm/@tarekraafat/autocomplete.js@10.2.4/dist/autoComplete.min.js"></script>
154154
<!-- <script src="./js/autoComplete.js"></script> -->
155155
<script src="./js/index.js"></script>
156156
</body>

‎docs/demo/js/autoComplete.js

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -274,14 +274,11 @@
274274
}
275275
});
276276

277-
var getData = function getData(ctx) {
277+
var getData = function getData(ctx, query) {
278278
return new Promise(function ($return, $error) {
279-
var input, query, data;
280-
input = ctx.input;
281-
query = ctx.query;
279+
var data;
282280
data = ctx.data;
283281
if (data.cache && data.store) return $return();
284-
query = query ? query(input.value) : input.value;
285282
return new Promise(function ($return, $error) {
286283
if (typeof data.src === "function") {
287284
return data.src(query).then($return, $error);
@@ -475,7 +472,7 @@
475472
queryVal = ctx.query ? ctx.query(queryVal) : queryVal;
476473
condition = checkTrigger(queryVal, ctx.trigger, ctx.threshold);
477474
if (condition) {
478-
return getData(ctx).then(function ($await_2) {
475+
return getData(ctx, queryVal).then(function ($await_2) {
479476
try {
480477
if (ctx.feedback instanceof Error) return $return();
481478
findMatches(queryVal, ctx);

‎docs/demo/js/autoComplete.js.gz

-31 Bytes
Binary file not shown.

‎docs/demo/js/autoComplete.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎docs/demo/js/autoComplete.min.js.gz

-15 Bytes
Binary file not shown.

‎docs/index.html

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@
158158
src="//platform-api.sharethis.com/js/sharethis.js#property=5c213660c276020011d38212&product=inline-share-buttons"
159159
async="async"></script>
160160
<link rel="stylesheet"
161-
href="https://cdn.jsdelivr.net/npm/@tarekraafat/autocomplete.js@10.2.3/dist/css/autoComplete.min.css">
161+
href="https://cdn.jsdelivr.net/npm/@tarekraafat/autocomplete.js@10.2.4/dist/css/autoComplete.min.css">
162162
</head>
163163

164164
<body>
@@ -209,7 +209,7 @@
209209
mustache: {
210210
data: ["../package.json", {
211211
minVersion: "10.2",
212-
version: "10.2.3"
212+
version: "10.2.4"
213213
}]
214214
}
215215
}
@@ -224,7 +224,7 @@
224224
<script src="https://cdn.jsdelivr.net/npm/docsify-example-panels"></script>
225225
<script src="//cdn.jsdelivr.net/npm/codeblock-iframe@latest/dist/index.min.js"></script>
226226
<script src="//cdn.jsdelivr.net/npm/docsify-codeblock-iframe@latest/dist/index.min.js"></script>
227-
<script src="https://cdn.jsdelivr.net/npm/@tarekraafat/autocomplete.js@10.2.3/dist/autoComplete.min.js"></script>
227+
<script src="https://cdn.jsdelivr.net/npm/@tarekraafat/autocomplete.js@10.2.4/dist/autoComplete.min.js"></script>
228228
</body>
229229

230230
</html>

‎docs/release-notes.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,10 @@ For more information on semantic versioning, please visit <http://semver.org/>.
3535

3636
***
3737

38-
### v10.2.3 ✨
38+
### v10.2.4 ✨
39+
- 🎛️ Updated: Library code with minor optimizations (Thanks 👍 @folknor) #256
40+
41+
### v10.2.3
3942
- 🔧 Fixed: `query` API issue (Thanks 👍 @folknor) #254
4043

4144
### v10.2.2

‎package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
2-
"version": "10.2.3",
2+
"version": "10.2.4",
33
"name": "@tarekraafat/autocomplete.js",
44
"description": "Simple autocomplete pure vanilla Javascript library.",
55
"keywords": [

‎src/controllers/dataController.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,11 @@ import search from "./searchController";
66
*
77
* @param {Object} ctx - autoComplete.js context
88
*/
9-
const getData = async (ctx) => {
10-
let { input, query, data } = ctx;
9+
const getData = async (ctx, query) => {
10+
const { data } = ctx;
1111

1212
if (data.cache && data.store) return;
1313

14-
query = query ? query(input.value) : input.value;
15-
1614
ctx.feedback = data.store = typeof data.src === "function" ? await data.src(query) : data.src;
1715

1816
/**

‎src/controllers/listController.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ const feedback = (ctx, index) => {
2525
* @param {Object} ctx - autoComplete.js context
2626
*/
2727
const render = (ctx) => {
28-
let { resultsList, list, resultItem, feedback } = ctx;
28+
const { resultsList, list, resultItem, feedback } = ctx;
2929
const { matches, results } = feedback;
3030

3131
// Reset cursor

‎src/services/init.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import eventEmitter from "../helpers/eventEmitter";
99
* @param {Object} ctx - autoComplete.js context
1010
*/
1111
export default async function (ctx) {
12-
let { placeHolder, resultsList } = ctx;
12+
const { placeHolder, resultsList } = ctx;
1313

1414
const parentAttrs = {
1515
role: "combobox",

‎src/services/start.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export default async function (ctx, q) {
1818
// Validate trigger condition
1919
if (condition) {
2020
// Get from source
21-
await getData(ctx);
21+
await getData(ctx, queryVal);
2222
// Check if data fetch failed
2323
if (ctx.feedback instanceof Error) return;
2424
// Find matching results to the query

0 commit comments

Comments
 (0)