Skip to content

No formatter for 'sql' files installed #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LordScree opened this issue Jun 17, 2020 · 6 comments
Open

No formatter for 'sql' files installed #7

LordScree opened this issue Jun 17, 2020 · 6 comments

Comments

@LordScree
Copy link

It is frustrating that Poor Man's T-SQL Formatter doesn't add a "formatter" for SQL files.

To reproduce:

  1. Add Poor Man's T-SQL Formatter extension
  2. Open a SQL file that contains some valid SQL
  3. Type CTRL+SHIFT+P to open the command pallette
  4. Type "Format Document" and select the command that appears

Expected: The document is formatted using Poor Man's T-SQL Formatter.
Actual: The user is presented with a message that reads "There is no formatter for 'sql' files installed".

Possibly related to issues #1 , #2 and #5
no-formatter

@Cirunz
Copy link

Cirunz commented Jan 19, 2021

I would add: I have another formatter installed (the "SQL Server (mssql)" extension), so I don't get the message "There is no formatter for 'sql' files installed", but still I just get "SQL Server (mssql)" as the only choice for formatting sql.

To reprodue:

  1. Add Poor Man's T-SQL Formatter extension
  2. Add any other sql formatter (in my case is "SQL Server (mssql)")
  3. Open a SQL file that contains some valid SQL
  4. Click with right mouse button or open the command palette and search for "Format document with..."

Expected: A seletion between "SQL Server (mssql)", "Poor Man's T-SQL Formatter" and "Configure Default Formatter..."
Actual: only "SQL Server (mssql)" and "Configure Default Formatter..." appear, and if I choose the latter, "SQL Server (mssql)" is the only formatter I can choose

@piotrgredowski
Copy link

@Cirunz, @LordScree
Unfortunately it looks like this extension is not maintained anymore, and not working for current versions of VSCode.
I've created a new one in which I'd like to maintain Poor Man's T-SQL Formatter as an extension for VSCode.
https://github.com/piotrgredowski/poor-mans-t-sql-formatter-vscode-extension

@LordScree
Copy link
Author

Thanks @piotrgredowski. I'll give your extension a go.

@walidhaidarii
Copy link

@Cirunz, @LordScree Unfortunately it looks like this extension is not maintained anymore, and not working for current versions of VSCode. I've created a new one in which I'd like to maintain Poor Man's T-SQL Formatter as an extension for VSCode. https://github.com/piotrgredowski/poor-mans-t-sql-formatter-vscode-extension

Hi @piotrgredowski can your extension be available for AZURE DATA STUDIO as well?
https://docs.microsoft.com/en-us/sql/azure-data-studio/download-azure-data-studio?view=sql-server-ver16

@piotrgredowski
Copy link

piotrgredowski commented May 31, 2022

@Cirunz, @LordScree Unfortunately it looks like this extension is not maintained anymore, and not working for current versions of VSCode. I've created a new one in which I'd like to maintain Poor Man's T-SQL Formatter as an extension for VSCode. https://github.com/piotrgredowski/poor-mans-t-sql-formatter-vscode-extension

Hi @piotrgredowski can your extension be available for AZURE DATA STUDIO as well? https://docs.microsoft.com/en-us/sql/azure-data-studio/download-azure-data-studio?view=sql-server-ver16

Hi @walidhaidarii. I'll try to do it soon. I just found that there's some guide about preparing such extension. I'll try and I will let you know in below issue.
piotrgredowski/poor-mans-t-sql-formatter-vscode-extension#7

edit:
@walidhaidarii vsix file is already published and I've tested - it's working with Azure Data Studio. Now it's not published and available through extension explorer in ADS. But you can install it from vsix file (google how to do it).
You can download vsix file from here and look for Download extension

@walidhaidarii
Copy link

that's was good news @piotrgredowski
special thanks for the hint 😉

You can download vsix file from here and look for Download extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants