Are trailing underscores in a url no longer allowed?

[roduyemi]

On v1.132.25 I can't have trailing underscores in any route param, e.g. https://example.com/golf__/ is redirected to https://example.com/golf/. This redirect didn't happen on v1.132.0-alpha.13. Is this change expected? I can see this PR landed, but I'm still seeing the same issue. Thanks

[nlynzaad]

Could you please provide a reproducible example on stackblitz or a github repo, we are busy relooking at this to enhance the experience and I would like to ensure we get as many of the pain points resolved.

That being said, a trailing underscore in a route path is regarded as an indication that the route should not be nested for example /foo/bar/baz and /foo/bar_/qux where baz is nested in both foo and bar and bar being the parent of baz, while qux will be regarded as nested only in foo with foo being the parent of qux.

This needs to both resolve to the path of /foo/bar/... and hence when resolving the route path the underscore is removed, but, and this is what the PR adressed, the url itself is left as is. Specifically the PR was focused on allowing path params in the url, with a trailing underscore, not to be affected but to be passed through correctly.

From what you mentioned, and this is purely based on the limited information available, it seems you have a route path /example/golf_ and want the url /example/golf_ to match this. Since the trailing underscore in the route path is removed this will not match since the route path is effectively /example/golf. Compare this to a route of /example/$golf_ and a url of /example/golf_ this will match with the $golf path param being equal to golf_.

[nlynzaad]

Thanks for the reproduction. seems the PR is causing problems with trailing slashes and when using code-based routing. We are stripping the trailing slash for file-based routing since it is indicative of a non-nested route.

This should not impact code-based routing and we are discussing internally how to address this in a better manner.

[roduyemi]

Thank you @nlynzaad, appreciate that 🙏

[matclayton]

Hey @nlynzaad any news on this? Sorry to ask and thank you for all the work on tanstack. This bug is preventing us from updating tanstack router, which in turn is our blocker for React streaming :( so just wondering if we need to fix a work around or its likely to land shortly.

[nlynzaad]

Just pushed a PR for this. You can follow #5402 for this. Hopefully will be resolved soon.

[matclayton]

Amazing, thank you so much!