Deno routes type-safety compatibility - help?

[sacha-c]

Hello!

I'm trying to start a new project using deno & tanstack router, however I am hitting my first bump along the road: I'm unable to get type-safety to work with my routes & Links.

For example:
Having the following file-structure (generated from the scaffold):

src
  routes
    __root.tsx
   about.tsx

Running deno task dev (deno run -A --node-modules-dir=auto npm:vite) generates the routeTree.gen.ts as expected, starts the application just fine, and navigation works.

However my problem is that if I make the following change to __root.tsx

function RootComponent() {
  ...
        <Link
          to="inexistent"

Deno does not complain about the incorrect type, although I would expect it to recognize that "inexistent" is not a valid route, as it does when using node with tsconfig, yarn etc.

Is this a problem of my setup with deno? For example I was looking around and found this, which makes me wonder if I should be adding extra configuration to my tsr.config.json
Or is this some kind of incompatibility of deno with some typescript used here?

Thanks in advance!

[schiller-manuel]

deno seems to not perform typechecking unless explicitly told to:

https://docs.deno.com/runtime/fundamentals/typescript/#type-checking

i just tried setting this up, but deno seems to fail type checking even when tsc succeeds

Check file:///private/tmp/my-router-app/src/main.tsx
TS2741 [ERROR]: Property 'search' is missing in type '{ children: string; to: "/about"; activeProps: { className: string; }; activeOptions: { exact: true; }; }' but required in type 'MakeRequiredSearchParams<Router<RootRoute<undefined, {}, AnyContext, AnyContext, {}, undefined, RootRouteChildren, FileRouteTypes>, ... 4 more ..., Record<...>>, string, "/about">'.
        <Link
         ~~~~
    at file:///private/tmp/my-router-app/src/routes/__root.tsx:13:10

    'search' is declared here.
        search: MakeRequiredParamsReducer<TRouter, 'SEARCH', TFrom, TTo> & {};
        ~~~~~~
        at file:///private/tmp/my-router-app/node_modules/.deno/@tanstack+react-router@1.102.0/node_modules/@tanstack/react-router/dist/esm/link.d.ts:70:5

TS2741 [ERROR]: Property 'search' is missing in type '{ children: string; to: "/about"; activeProps: { className: string; }; }' but required in type 'MakeRequiredSearchParams<Router<RootRoute<undefined, {}, AnyContext, AnyContext, {}, undefined, RootRouteChildren, FileRouteTypes>, ... 4 more ..., Record<...>>, string, "/about">'.
        <Link
         ~~~~
    at file:///private/tmp/my-router-app/src/routes/__root.tsx:22:10

    'search' is declared here.
        search: MakeRequiredParamsReducer<TRouter, 'SEARCH', TFrom, TTo> & {};
        ~~~~~~
        at file:///private/tmp/my-router-app/node_modules/.deno/@tanstack+react-router@1.102.0/node_modules/@tanstack/react-router/dist/esm/link.d.ts:70:5

TS2345 [ERROR]: Argument of type 'string' is not assignable to parameter of type 'never'.
export const Route = createFileRoute('/about')({
                                     ~~~~~~~~
    at file:///private/tmp/my-router-app/src/routes/about.tsx:4:38

TS2345 [ERROR]: Argument of type 'string' is not assignable to parameter of type 'never'.
export const Route = createFileRoute('/')({
                                     ~~~
    at file:///private/tmp/my-router-app/src/routes/index.tsx:4:38

Found 4 errors.

error: Type checking failed.

I have seen similar errors when strict: true was not enabled in tsconfig.json, but apparently deno defaults to that value.

[sacha-c]

Hmm that is strange

Just to be sure we're on the same page, here is a link to my reproduction repo: https://github.com/sacha-c/tanstack-router-deno-repro
Using deno 2.1.9

Running a few commands I would expect to fail, but they all succeed:

❯ deno task dev
Task dev deno run -A --node-modules-dir=auto npm:vite

♻️  Generating routes...
✅ Processed routes in 59ms

  VITE v6.1.0  ready in 264 ms

  ➜  Local:   http://localhost:5173/
  ➜  Network: use --host to expose
  ➜  press h + enter to show help
^C%                                                                                                                                                              
❯ deno lint
Checked 6 files
❯ deno check src/routes/__root.tsx
Check file:///.../tanstack-router-deno-repro/src/routes/__root.tsx

And yes, it looks like typechecking isn't working on router components (or at least Link), here the deno extension which type-checks doesn't recognize the following:

[litewarp]

Just an FYI for all you deno heads out there, this is a bug with deno check -- the lsp should work correctly though -- see denoland/deno#28370