Route search params reloads state on link hover

[BenJeau]

Hi,

I've looked around and this seems to be possibly a bug (unless I have misconfigured how I'm using search params within TanStack router), but when I hover a link, even when I didn't click on the link, it loads the new search param within the state of my component.

Here's an example of it happening, you can see in the devtool (and URL, but forgot to grab it in the recording) that it didn't update when I hovered yet the code updated within the name field from Micor to Testing.

I use the router with TanStack Router where I have defaultPreload: "intent" set within my main router, but still wouldn't expect the behaviour of search params affecting on hover.

To add on, I get the search params within the relevant page component using Route.useSearch();

[BenJeau]

I was able to reproduce it here https://stackblitz.com/edit/github-3yrcd5 the main culprit seems to be because of defaultPreloadStaleTime: 0

[BenJeau]

I was following the docs here https://tanstack.com/router/v1/docs/guide/data-loading#passing-all-loader-events-to-an-external-cache saying to use it for external loaders such as TanStack Query, but it seems to have other side effects?

[SeanCassiere]

Could you try adding this in your route?

export const Route = createFileRoute({
  // ...,
  loaderDeps: ({ search }) => ({ search }), // <- this right here
});

[schiller-manuel]

@SeanCassiere yes this makes the problem go away: https://stackblitz.com/edit/github-3yrcd5-1o2qe2?file=src%2Fmain.tsx
but is this the expected behavior without loaderDeps?

[SeanCassiere]

Probably isn't.

It's something I remember from this issue and eventually loaderDeps came out.

We could prevent committing the location to primary if in preload I think.

[BenJeau]

I've tried that and it seems to have gone away, but I've just updated to the latest version and switch my router from new Router to createRouter and everything seems fixed without having to do the loaderDeps: ({ search }) => ({ search }) trick