Skip to content

Commit f18fc0a

Browse files
committed
fix: onClick now passes focused, not undefined
1 parent ee0cb70 commit f18fc0a

File tree

1 file changed

+18
-20
lines changed

1 file changed

+18
-20
lines changed

src/components/ChartInner.tsx

Lines changed: 18 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,12 @@ export default React.forwardRef(function ChartInner(
3333
seriesOptions,
3434
getSeriesOrder,
3535
focused,
36-
focusedElement,
36+
focused,
3737
getOnClick,
3838
} = useChartContext();
3939

40-
const [offset] = useChartState((d) => d.offset);
41-
const [setOffset, setChartState] = useChartState((d) => d.setOffset);
40+
const [offset] = useChartState(d => d.offset);
41+
const [setOffset, setChartState] = useChartState(d => d.setOffset);
4242

4343
useIsomorphicLayoutEffect(() => {
4444
if (!svgRef.current) {
@@ -55,9 +55,9 @@ export default React.forwardRef(function ChartInner(
5555
}
5656
});
5757

58-
const onMouseLeave = (e) => {
59-
setChartState((old) => ({ ...old, focused: null }));
60-
setChartState((old) => ({
58+
const onMouseLeave = e => {
59+
setChartState(old => ({ ...old, focused: null }));
60+
setChartState(old => ({
6161
...old,
6262
pointer: {
6363
...old.pointer,
@@ -68,15 +68,15 @@ export default React.forwardRef(function ChartInner(
6868

6969
const rafRef = React.useRef();
7070

71-
const onMouseMove = (e) => {
71+
const onMouseMove = e => {
7272
if (rafRef.current) {
7373
Raf.cancel(rafRef.current);
7474
}
7575
rafRef.current = Raf(() => {
7676
rafRef.current = null;
7777
const { clientX, clientY } = e;
7878

79-
setChartState((old) => {
79+
setChartState(old => {
8080
const x = clientX - offset.left - gridX;
8181
const y = clientY - offset.top - gridY;
8282

@@ -100,7 +100,7 @@ export default React.forwardRef(function ChartInner(
100100
document.removeEventListener('mouseup', onMouseUp);
101101
document.removeEventListener('mousemove', onMouseMove);
102102

103-
setChartState((old) => {
103+
setChartState(old => {
104104
return {
105105
...old,
106106
pointer: {
@@ -120,7 +120,7 @@ export default React.forwardRef(function ChartInner(
120120
document.addEventListener('mouseup', onMouseUp);
121121
document.addEventListener('mousemove', onMouseMove);
122122

123-
setChartState((old) => ({
123+
setChartState(old => ({
124124
...old,
125125
pointer: {
126126
...old.pointer,
@@ -136,7 +136,7 @@ export default React.forwardRef(function ChartInner(
136136
const orderedStackData = getSeriesOrder(reversedStackData);
137137

138138
const focusedSeriesIndex = focused
139-
? orderedStackData.findIndex((series) => series.id === focused.series.id)
139+
? orderedStackData.findIndex(series => series.id === focused.series.id)
140140
: -1;
141141

142142
// Bring focused series to the front
@@ -148,7 +148,7 @@ export default React.forwardRef(function ChartInner(
148148
]
149149
: orderedStackData;
150150

151-
const stacks = focusOrderedStackData.map((stack) => {
151+
const stacks = focusOrderedStackData.map(stack => {
152152
return (
153153
<stack.Component
154154
key={stack.id}
@@ -180,9 +180,7 @@ export default React.forwardRef(function ChartInner(
180180
position: 'absolute',
181181
...style,
182182
}}
183-
onClick={
184-
getOnClick() ? (e) => getOnClick()(focusedElement, e) : undefined
185-
}
183+
onClick={getOnClick() ? e => getOnClick()(focused, e) : undefined}
186184
>
187185
<svg
188186
ref={svgRef}
@@ -191,10 +189,10 @@ export default React.forwardRef(function ChartInner(
191189
height,
192190
overflow: 'hidden',
193191
}}
194-
onMouseEnter={(e) => e.persist() || onMouseMove(e)}
195-
onMouseMove={(e) => e.persist() || onMouseMove(e)}
196-
onMouseLeave={(e) => e.persist() || onMouseLeave(e)}
197-
onMouseDown={(e) => e.persist() || onMouseDown(e)}
192+
onMouseEnter={e => e.persist() || onMouseMove(e)}
193+
onMouseMove={e => e.persist() || onMouseMove(e)}
194+
onMouseLeave={e => e.persist() || onMouseLeave(e)}
195+
onMouseDown={e => e.persist() || onMouseDown(e)}
198196
>
199197
{width && height ? (
200198
<>
@@ -215,7 +213,7 @@ export default React.forwardRef(function ChartInner(
215213
/>
216214
<Voronoi />
217215
<g className="axes">
218-
{[...primaryAxes, ...secondaryAxes].map((axis) => (
216+
{[...primaryAxes, ...secondaryAxes].map(axis => (
219217
<Axis key={axis.id} {...axis} />
220218
))}
221219
</g>

0 commit comments

Comments
 (0)