perf: improve performance of util function "difference" in quriesObserver.ts in query-core package (#9201)

novice0840 · web-flow · commit 57c6ce149b52 · 2025-06-03T13:18:02.000+02:00
* perf: change "difference" util function

* refactor: extract "new Set" function in "difference" util function
diff --git a/packages/query-core/src/queriesObserver.ts b/packages/query-core/src/queriesObserver.ts
@@ -10,7 +10,8 @@ import type {
 import type { QueryClient } from './queryClient'
 
 function difference<T>(array1: Array<T>, array2: Array<T>): Array<T> {
-  return array1.filter((x) => !array2.includes(x))
+  const excludeSet = new Set(array2)
+  return array1.filter((x) => !excludeSet.has(x))
 }
 
 function replaceAt<T>(array: Array<T>, index: number, value: T): Array<T> {

Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,8 @@ import type {`
`10`	`10`	`import type { QueryClient } from './queryClient'`
`11`	`11`
`12`	`12`	`function difference<T>(array1: Array<T>, array2: Array<T>): Array<T> {`
`13`		`- return array1.filter((x) => !array2.includes(x))`
	`13`	`+ const excludeSet = new Set(array2)`
	`14`	`+ return array1.filter((x) => !excludeSet.has(x))`
`14`	`15`	`}`
`15`	`16`
`16`	`17`	`function replaceAt<T>(array: Array<T>, index: number, value: T): Array<T> {`