Skip to content

Commit f4c4880

Browse files
authored
merge: 논의 사항 합의 (#20)
2 parents f44249a + 21fe228 commit f4c4880

23 files changed

+95
-200
lines changed

packages/react-native/src/components/common/Header.tsx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,6 @@ import React, { ReactElement, useEffect, useMemo } from 'react';
33
import { View } from 'react-native';
44
import { useNavigation } from '@react-navigation/native';
55
import BackIcon from '@/assets/BackIcon';
6-
import { useHeaderState } from '@/stores/header';
76
import { HEADER_STYLE } from '@/constants/HEADER_STYLE';
87

98
interface HeaderProps {
@@ -17,7 +16,6 @@ export default function Header({
1716
RightActionButton,
1817
onBack,
1918
}: HeaderProps) {
20-
const { showHeader } = useHeaderState();
2119
const navigation = useNavigation();
2220

2321
const Right = useMemo(
@@ -42,8 +40,6 @@ export default function Header({
4240
return;
4341
}
4442

45-
showHeader();
46-
4743
navigation.setOptions({
4844
...HEADER_STYLE,
4945
headerShown: true,

packages/react-native/src/components/maps/RecordCard.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@ import {
77
import { Font } from 'design-system';
88
import { useNavigation } from '@react-navigation/native';
99
import DotMenuIcon from '@/assets/DotMenuIcon';
10-
import { MapsStackNavigation } from '@/types/navigation';
1110
import { KoreaLocationName } from '@/types/map';
11+
import { StackNavigation } from '@/types/navigation';
1212

1313
interface CardProps {
1414
id: number;
@@ -29,7 +29,7 @@ export default function RecordCard({
2929
date,
3030
backgroundImage,
3131
}: CardProps) {
32-
const navigation = useNavigation<MapsStackNavigation<'Maps/Record'>>();
32+
const navigation = useNavigation<StackNavigation<'Maps/Record'>>();
3333
return (
3434
<TouchableOpacity
3535
onPress={() =>

packages/react-native/src/components/signup/common/Header.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,6 @@
11
import { TouchableOpacity } from 'react-native-gesture-handler';
22
import Cancel from '@/assets/CancelIcon';
33
import Header from '@/components/common/Header';
4-
import { SignupStackNavigation } from '@/types/navigation';
5-
import { SignupStackParamList } from '@/routes/SignupStackNavigator';
64

75
interface HeaderProps {
86
onBack: () => void;

packages/react-native/src/layouts/BackGroundGradient.tsx

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { SafeAreaView, ScrollView } from 'react-native';
22
import LinearGradient from 'react-native-linear-gradient';
33
import { useHeaderHeight } from '@react-navigation/elements';
44
import { useSafeAreaInsets } from 'react-native-safe-area-context';
5-
import { useHeaderState } from '@/stores/header';
65

76
export default function BackGroundGradient({
87
children,
@@ -14,8 +13,6 @@ export default function BackGroundGradient({
1413
const headerHeight = useHeaderHeight();
1514
const insets = useSafeAreaInsets();
1615

17-
const { headerShown } = useHeaderState();
18-
1916
return (
2017
<LinearGradient
2118
colors={['#FF1919', '#000000']}
@@ -34,7 +31,7 @@ export default function BackGroundGradient({
3431
showsVerticalScrollIndicator={false}
3532
className="flex-1"
3633
style={{
37-
marginTop: headerShown ? headerHeight - insets.top : marginTop,
34+
marginTop: headerHeight - insets.top + marginTop,
3835
}}
3936
>
4037
{children}

packages/react-native/src/pages/Detail.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,12 @@ import { useRoute } from '@react-navigation/native';
22
import { View } from 'react-native';
33
import { Font } from 'design-system';
44
import Carousel from 'react-native-reanimated-carousel';
5-
import { HomeRouteProps } from '@/types/navigation';
65
import BackGroundGradient from '@/layouts/BackGroundGradient';
76
import { SpotData } from '@/types/spot';
87
import Card from '@/components/common/Card';
98
import WordBreak from '@/components/common/WordBreak';
9+
import Header from '@/components/common/Header';
10+
import { StackRouteProps } from '@/types/navigation';
1011

1112
// FIXME: 추후 제거
1213
const mockData: SpotData[] = [
@@ -46,11 +47,12 @@ const mockDescription =
4647
'"너와 함께한 시간 모두 눈부셨다. 날이 좋아서, 날이 좋지 않아서, 날이 적당해서 모든 날이 좋았다."';
4748

4849
export default function Detail() {
49-
const route = useRoute<HomeRouteProps<'home/detail'>>();
50+
const route = useRoute<StackRouteProps<'Home/Detail'>>();
5051
const { title } = route.params;
5152

5253
return (
5354
<BackGroundGradient>
55+
<Header />
5456
<View className="items-center">
5557
<Font.Bold type="mainTitle" color="white">
5658
{title}

packages/react-native/src/pages/Home.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@ import { Button, Font } from 'design-system';
33
import CardSlider from '@components/CardSlider';
44
import SearchBar from '@components/common/SearchBar';
55
import { SpotData } from '@/types/spot';
6-
import { HomeStackNavigation } from '@/types/navigation';
76
import BackGroundGradient from '@/layouts/BackGroundGradient';
87
import useNicknameQuery from '@/apis/queries/useNicknameQuery';
8+
import { StackNavigation } from '@/types/navigation';
99

1010
const mockData: SpotData[] = [
1111
{
@@ -60,14 +60,14 @@ const mockData: SpotData[] = [
6060
];
6161

6262
interface HomeScreenProps {
63-
navigation: HomeStackNavigation<'home/main'>;
63+
navigation: StackNavigation<'Home/Main'>;
6464
}
6565

6666
export default function Home({ navigation }: HomeScreenProps) {
6767
const { nickname } = useNicknameQuery();
6868

6969
return (
70-
<BackGroundGradient>
70+
<BackGroundGradient marginTop={40}>
7171
<View className="flex flex-col gap-10 p-4">
7272
<View>
7373
<Font type="title1" color="white">
@@ -82,7 +82,7 @@ export default function Home({ navigation }: HomeScreenProps) {
8282
<SearchBar
8383
placeholder="드라마/영화 제목을 검색하세요."
8484
handleSearch={(title) =>
85-
navigation.navigate('home/detail', { title })
85+
navigation.navigate('Home/Detail', { title })
8686
}
8787
/>
8888
</View>

packages/react-native/src/pages/Login/Login.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@ import { SafeAreaView, View } from 'react-native';
22
import LinearGradient from 'react-native-linear-gradient';
33
import SPOTLogo from '@assets/SPOTLogo';
44
import { SocialLogin } from 'design-system';
5-
import { ScreenNavigationProp } from '@/types/navigation';
5+
import { StackNavigation } from '@/types/navigation';
66
import { AppStorage } from '@/utils/storage';
77

88
interface LoginPageProps {
9-
navigation: ScreenNavigationProp<'Login'>;
9+
navigation: StackNavigation<'Login'>;
1010
}
1111

1212
export default function Login({ navigation }: LoginPageProps) {
@@ -18,7 +18,7 @@ export default function Login({ navigation }: LoginPageProps) {
1818
return navigation.navigate('Signup');
1919
}
2020

21-
return navigation.navigate('Main');
21+
return navigation.reset({ routes: [{ name: 'Main' }] });
2222
};
2323

2424
return (

packages/react-native/src/pages/Maps/Maps.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,10 +10,10 @@ import BottomSheet, {
1010
} from '@gorhom/bottom-sheet';
1111
import mapData from '@/assets/mapData';
1212
import { KoreaLocationName } from '@/types/map';
13-
import { MapsStackNavigation } from '@/types/navigation';
13+
import { StackNavigation } from '@/types/navigation';
1414

1515
interface MapsMainProps {
16-
navigation: MapsStackNavigation<'Maps/Main'>;
16+
navigation: StackNavigation<'Maps/Main'>;
1717
}
1818

1919
const { width, height } = Dimensions.get('window');

packages/react-native/src/pages/Maps/RecordDetail.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,16 +5,16 @@ import { Font } from 'design-system';
55
import useRecordDetailQuery from '@/apis/queries/records/useRecordDetailQuery';
66
import Header from '@/components/common/Header';
77
import BackGroundGradient from '@/layouts/BackGroundGradient';
8-
import { MapsRouteProps, MapsStackNavigation } from '@/types/navigation';
8+
import { StackNavigation, StackRouteProps } from '@/types/navigation';
99

1010
interface LogDetailProps {
11-
navigation: MapsStackNavigation<'Maps/RecordDetail'>;
11+
navigation: StackNavigation<'Maps/RecordDetail'>;
1212
}
1313

1414
const { width: fullWidth } = Dimensions.get('window');
1515

1616
export default function RecordDetail({ navigation }: LogDetailProps) {
17-
const route = useRoute<MapsRouteProps<'Maps/RecordDetail'>>();
17+
const route = useRoute<StackRouteProps<'Maps/RecordDetail'>>();
1818
const [currentIndex, setCurrentIndex] = useState(0);
1919

2020
const { recordDetail } = useRecordDetailQuery({

packages/react-native/src/pages/Maps/Records.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,21 +3,21 @@ import { useRoute } from '@react-navigation/native';
33
import SortIcon from '@/assets/SortIcon';
44
import FloatingPlusButton from '@/components/maps/FloatingPlusButton';
55
import BackGroundGradient from '@/layouts/BackGroundGradient';
6-
import { MapsRouteProps, MapsStackNavigation } from '@/types/navigation';
76
import { LOG_PADDING_X } from '@/components/maps/RecordCard';
87
import RecordCardList from '@/components/maps/RecordCardList';
98
import Header from '@/components/common/Header';
9+
import { StackNavigation, StackRouteProps } from '@/types/navigation';
1010

1111
interface RecordsProps {
12-
navigation: MapsStackNavigation<'Maps/Record'>;
12+
navigation: StackNavigation<'Maps/Record'>;
1313
}
1414

1515
export default function Records({ navigation }: RecordsProps) {
1616
const sort = () => {
1717
// TODO: 실제 구현 필요(현재 UI없음)
1818
};
1919

20-
const route = useRoute<MapsRouteProps<'Maps/Record'>>();
20+
const route = useRoute<StackRouteProps<'Maps/Record'>>();
2121
return (
2222
<View>
2323
<BackGroundGradient>

0 commit comments

Comments
 (0)