Error on ODD to Compiled ODD conversion if @type value in <title> one of sample values

[SebastianKohler]

https://tei-c.org/release/doc/tei-p5-doc/en/html/ref-title.html lists main, sub etc. as sample values for @type on <title>.

When I add any of the sample values to @type on <title> in my TEI ODD file and try converting to a compiled ODD, TEIGarage gives an error:

Error: class pl.psnc.dl.ege.exception.ConverterException

Processing terminated by xsl:message at line 1952 in odd2odd.xsl

My <elementSpec> for <title> looks like this:

<elementSpec ident="title" mode="change">
	<attList>
		<attDef ident="period" mode="delete"/>
		<attDef ident="when-custom" mode="delete"/>
		<attDef ident="notBefore-custom" mode="delete"/>
		<attDef ident="notAfter-custom" mode="delete"/>
		<attDef ident="from-custom" mode="delete"/>
		<attDef ident="to-custom" mode="delete"/>
		<attDef ident="datingPoint" mode="delete"/>
		<attDef ident="datingMethod" mode="delete"/>
		<attDef ident="when-iso" mode="delete"/>
		<attDef ident="notBefore-iso" mode="delete"/>
		<attDef ident="notAfter-iso" mode="delete"/>
		<attDef ident="from-iso" mode="delete"/>
		<attDef ident="to-iso" mode="delete"/>
		<attDef ident="ana" mode="delete"/>
		<attDef ident="change" mode="delete"/>
		<attDef ident="corresp" mode="delete"/>
		<attDef ident="synch" mode="delete"/>
		<attDef ident="sameAs" mode="delete"/>
		<attDef ident="copyOf" mode="delete"/>
		<attDef ident="next" mode="delete"/>
		<attDef ident="prev" mode="delete"/>
		<attDef ident="exclude" mode="delete"/>
		<attDef ident="select" mode="delete"/>
		<attDef ident="xml:id" mode="delete"/>
		<attDef ident="n" mode="delete"/>
		<attDef ident="xml:base" mode="delete"/>
		<attDef ident="xml:space" mode="delete"/>
		<attDef ident="facs" mode="delete"/>
		<attDef ident="resp" mode="delete"/>
		<attDef ident="source" mode="delete"/>
		<attDef ident="subtype" mode="delete"/>
		<attDef ident="rend" mode="change">
			<valList type="closed" mode="change">
				<valItem mode="add" ident="bold"/>
				<valItem mode="add" ident="italics"/>
			</valList>
		</attDef>
		<attDef ident="type" mode="change">
			<valList type="closed" mode="change">
				<valItem mode="add" ident="host">
					<desc versionDate="2025-03-13" xml:lang="en">the title applies to a publication (journal, magazine, newspaper, anthology etc.), which acts as a container or host item for analytic items (e.g. articles, poems, or other works published as part of a larger item).</desc>
				</valItem>
				<valItem mode="add" ident="main">
					<desc versionDate="2025-05-07" xml:lang="en">the main title of the work in the document.</desc>
				</valItem>
			</valList>
		</attDef>
		<attDef ident="calendar" mode="delete"/>
		<attDef ident="level" mode="delete"/>
	</attList>
</elementSpec>

If I change <valItem mode="add" ident="main"> to a value that is not one of the sample values, the conversion is successful.

Why can't I add any of the sample values?

[SebastianKohler]

OK so the conversion is successful if I change the mode from

<valItem mode="add" ident="main">

to

<valItem mode="replace" ident="main">

which I think is a bit counterintuitive, since if I omit the sample values from the <valList>, they won't be automatically added when converting to XSD Schema for instance.

[peterstadler]

Hi @SebastianKohler, thanks for raising this issue!

There's currently an issue with the propagation of error messages originating from xml:messages, so TEIGarage won't display the actual error message but only an error. If you run the transformation locally (with e.g. bin/oddtorng) you'll receive an error message like this:

Convert /Users/pstadler/temp/teigarage-issue132.odd to /Users/pstadler/temp/teigarage-issue132.rng (odd to rng) using profile default lang=en
     [echo] Do ODD expand processing (schema ) 
     [xslt] Asked to add attr main of type of title but it already exists; perhaps use @mode of 'change' or 'replace' instead.

BUILD FAILED
/Users/pstadler/repos/Stylesheets/rng/build-to.xml:29: The following error occurred while executing this line:
/Users/pstadler/repos/Stylesheets/common/teianttasks.xml:388: Fatal error during transformation using /Users/pstadler/repos/Stylesheets/odds/odd2odd.xsl: Processing terminated by xsl:message at line 1952 in odd2odd.xsl; SystemID: file:/Users/pstadler/repos/Stylesheets/odds/odd2odd.xsl; Line#: 1952; Column#: 52

That's exactly what you did to fix it :)

That said, I can't reproduce your issue when the <valItem mode="add" ident="main"> is omitted. For me, the sample values are visible in the resulting schema even when the valList is changed to @type="closed".

So, given this schemaSpec:

<schemaSpec ident="oddex1" start="TEI">
  <moduleRef key="header"/>
  <moduleRef key="core"/>
  <moduleRef key="tei"/>
  <moduleRef key="textstructure"/>
  <elementSpec ident="title" mode="change">
    <attList>
      <attDef ident="period" mode="delete"/>
      <attDef ident="when-custom" mode="delete"/>
      <attDef ident="notBefore-custom" mode="delete"/>
      <attDef ident="notAfter-custom" mode="delete"/>
      <attDef ident="from-custom" mode="delete"/>
      <attDef ident="to-custom" mode="delete"/>
      <attDef ident="datingPoint" mode="delete"/>
      <attDef ident="datingMethod" mode="delete"/>
      <attDef ident="when-iso" mode="delete"/>
      <attDef ident="notBefore-iso" mode="delete"/>
      <attDef ident="notAfter-iso" mode="delete"/>
      <attDef ident="from-iso" mode="delete"/>
      <attDef ident="to-iso" mode="delete"/>
      <attDef ident="ana" mode="delete"/>
      <attDef ident="change" mode="delete"/>
      <attDef ident="corresp" mode="delete"/>
      <attDef ident="synch" mode="delete"/>
      <attDef ident="sameAs" mode="delete"/>
      <attDef ident="copyOf" mode="delete"/>
      <attDef ident="next" mode="delete"/>
      <attDef ident="prev" mode="delete"/>
      <attDef ident="exclude" mode="delete"/>
      <attDef ident="select" mode="delete"/>
      <attDef ident="xml:id" mode="delete"/>
      <attDef ident="n" mode="delete"/>
      <attDef ident="xml:base" mode="delete"/>
      <attDef ident="xml:space" mode="delete"/>
      <attDef ident="facs" mode="delete"/>
      <attDef ident="resp" mode="delete"/>
      <attDef ident="source" mode="delete"/>
      <attDef ident="subtype" mode="delete"/>
      <attDef ident="rend" mode="change">
        <valList type="closed" mode="change">
          <valItem mode="add" ident="bold"/>
          <valItem mode="add" ident="italics"/>
        </valList>
      </attDef>
      <attDef ident="type" mode="change">
        <valList type="closed" mode="change">
          <valItem mode="add" ident="host">
            <desc versionDate="2025-03-13" xml:lang="en">the title applies to a publication (journal, magazine, newspaper, anthology etc.), which acts as a container or host item for analytic items (e.g. articles, poems, or other works published as part of a larger item).</desc>
          </valItem>
          <!--<valItem mode="add" ident="main">
            <desc versionDate="2025-05-07" xml:lang="en">the main title of the work in the document.</desc>
          </valItem>-->
        </valList>
      </attDef>
      <attDef ident="calendar" mode="delete"/>
      <attDef ident="level" mode="delete"/>
    </attList>
  </elementSpec>
</schemaSpec>

will result in this RelaxNG (excerpt):

<attribute name="type">
   <a:documentation xmlns:a="http://relaxng.org/ns/compatibility/annotations/1.0">classifies the title according to some convenient typology.</a:documentation>
   <choice>
      <value>main</value>
      <a:documentation xmlns:a="http://relaxng.org/ns/compatibility/annotations/1.0">main title</a:documentation>
      <value>sub</value>
      <a:documentation xmlns:a="http://relaxng.org/ns/compatibility/annotations/1.0">(subordinate) subtitle, title of part</a:documentation>
      <value>alt</value>
      <a:documentation xmlns:a="http://relaxng.org/ns/compatibility/annotations/1.0">(alternate) alternate title, often in another language, by which the work is also known</a:documentation>
      <value>short</value>
      <a:documentation xmlns:a="http://relaxng.org/ns/compatibility/annotations/1.0">abbreviated form of title</a:documentation>
      <value>desc</value>
      <a:documentation xmlns:a="http://relaxng.org/ns/compatibility/annotations/1.0">(descriptive) descriptive paraphrase of the work functioning as a title</a:documentation>
      <value>host</value>
      <a:documentation xmlns:a="http://relaxng.org/ns/compatibility/annotations/1.0">the title applies to a publication (journal, magazine, newspaper, anthology etc.), which acts as a container or host item for analytic items (e.g. articles, poems, or other works published as part of a larger item).</a:documentation>
   </choice>
</attribute>

[SebastianKohler]

OK, thank you!

I think the reason I don't get the sample values is that I also have this in my ODD:

<classSpec ident="att.typed" type="atts" mode="change">
	<attList>
		<attDef ident="type" mode="change">
			<valList type="closed" mode="change"/>
		</attDef>
		<attDef ident="subtype" mode="change">
			<valList type="closed" mode="change"/>
		</attDef>
	</attList>
</classSpec>

This clears the in-built values of @type and @subtype, at least when converting to XSD Schema.

[peterstadler]

I think this is more of a Stylesheets issue so I'm transferring this issue there!