2023-07-05 - Multiple fixes

- Info prompt when changing account and closing method is different to suggested. TaskKill for BattleNet does not close games, whereas Close or Combined may (as BattleNet has time to close games before itself).
- Fixed crash when saving accounts and folder does not exist.
- Fixed rare corruption of Steam's loginusers.vdf on forget account

Author: TCNOco

TcNo-Acc-Switcher-Globals/Globals.cs

@@ -27,7 +27,7 @@ public partial class Globals
 #pragma warning disable CA2211 // Non-constant fields should not be visible - This is necessary due to it being a launch parameter.
         public static bool VerboseMode;
 #pragma warning restore CA2211 // Non-constant fields should not be visible
-        public static readonly string Version = "2023-06-27_01";
+        public static readonly string Version = "2023-07-05_00";
 
         #region INITIALISATION
 

TcNo-Acc-Switcher-Server/Pages/Basic/BasicSwitcherBase.cs

@@ -1,6 +1,8 @@
 using System.Runtime.Versioning;
 using Microsoft.JSInterop;
 using TcNo_Acc_Switcher_Globals;
+using TcNo_Acc_Switcher_Server.Data;
+using TcNo_Acc_Switcher_Server.Pages.General;
 
 namespace TcNo_Acc_Switcher_Server.Pages.Basic
 {
@@ -34,7 +36,15 @@ public static void NewLogin_Basic()
         public static void BasicAddCurrent(string accName)
         {
             Globals.DebugWriteLine(@"[JSInvoke:Basic\BasicSwitcherBase.BasicAddCurrent] accName:hidden");
-            _ = BasicSwitcherFuncs.BasicAddCurrent(accName);
+            try
+            {
+                _ = BasicSwitcherFuncs.BasicAddCurrent(accName);
+            }
+            catch (System.IO.DirectoryNotFoundException io)
+            {
+                _ = GeneralInvocableFuncs.ShowToast("error", Lang.Instance["Toast_RestartAsAdmin"], Lang.Instance["Failed"], "toastarea");
+                Globals.WriteToLog($"Failed to BasicAddCurrent. DirectoryNotFoundException", io);
+            }
         }
     }
 }

TcNo-Acc-Switcher-Server/Pages/Basic/BasicSwitcherFuncs.cs

@@ -5,12 +5,14 @@
 using System.Runtime.Versioning;
 using System.Text.RegularExpressions;
 using System.Threading.Tasks;
+using Microsoft.AspNetCore.Components.RenderTree;
 using Microsoft.JSInterop;
 using Newtonsoft.Json;
 using Newtonsoft.Json.Linq;
 using TcNo_Acc_Switcher_Globals;
 using TcNo_Acc_Switcher_Server.Data;
 using TcNo_Acc_Switcher_Server.Pages.General;
+using static SteamKit2.Internal.CMsgClientAMGetPersonaNameHistory;
 using BasicSettings = TcNo_Acc_Switcher_Server.Data.Settings.Basic;
 
 namespace TcNo_Acc_Switcher_Server.Pages.Basic
@@ -481,6 +483,12 @@ private static bool BasicCopyInAccount(string accId)
         private static bool KillGameProcesses()
         {
             // Kill game processes
+            if (BasicSettings.ClosingMethod != CurrentPlatform.ClosingMethod)
+            {
+                _ = GeneralInvocableFuncs.ShowToast("info", Lang["Toast_DifferentClosingMethod",
+                    new { defaultMethod = CurrentPlatform.ClosingMethod, currentMethod = BasicSettings.ClosingMethod }], renderTo: "toastarea", duration: 15000);
+            }
+
             _ = AppData.InvokeVoidAsync("updateStatus", Lang["Status_ClosingPlatform", new { platform = CurrentPlatform.FullName }]);
             if (!GeneralFuncs.CloseProcesses(CurrentPlatform.ExesToEnd, BasicSettings.ClosingMethod))
             {
@@ -535,6 +543,13 @@ public static bool BasicAddCurrent(string accName)
                 // Unique ID file, and does not already exist: Therefore create!
                 var uniqueIdFile = CurrentPlatform.GetUniqueFilePath();
                 uniqueId = Globals.RandomString(16);
+
+                var uniqueIdDir = Path.GetDirectoryName(uniqueIdFile);
+                if (!Directory.Exists(uniqueIdDir))
+                {
+                    Directory.CreateDirectory(uniqueIdDir);
+                }
+
                 File.WriteAllText(uniqueIdFile, uniqueId);
             }
 

TcNo-Acc-Switcher-Server/Pages/Steam/Index.razor.cs

@@ -30,7 +30,7 @@ public class Steamuser
             [JsonProperty("mostrecent", Order = 3)] public string MostRec = "0";
             [JsonProperty("Timestamp", Order = 4)] public string LastLogin { get; set; }
             [JsonProperty("WantsOfflineMode", Order = 5)] public string OfflineMode = "0";
-            [JsonProperty("SkipOfflineModeWarning", Order = 6)] public string SkipOfflineModeWarning { get; set; }
+            [JsonProperty("SkipOfflineModeWarning", Order = 6)] public string SkipOfflineModeWarning { get; set; } = "0";
 
             [JsonIgnore] public string ImageDownloadUrl { get; set; }
             [JsonIgnore] public string ImgUrl { get; set; }

TcNo-Acc-Switcher-Server/Pages/Steam/SteamSwitcherFuncs.cs

@@ -163,20 +163,18 @@ public static string GetCurrentAccountId()
                 Index.Steamuser mostRecent = null;
                 foreach (var su in AppData.SteamUsers)
                 {
-                    int.TryParse(su.LastLogin, out var last);
+                    _ = int.TryParse(su.LastLogin, out int last);
 
-                    int.TryParse(mostRecent?.LastLogin, out var recent);
+                    _ = int.TryParse(mostRecent?.LastLogin, out int recent);
 
                     if (mostRecent == null || last > recent)
                         mostRecent = su;
                 }
 
-                int.TryParse(mostRecent.LastLogin, out var mrTimestamp);
+                if (mostRecent is null) return "";
 
-                if (SteamSettings.LastAccTimestamp > mrTimestamp)
-                {
+                if (int.TryParse(mostRecent?.LastLogin, out var mrTimestamp) && SteamSettings.LastAccTimestamp > mrTimestamp)
                     return SteamSettings.LastAccName;
-                }
 
                 return mostRecent.SteamId ?? "";
             }
@@ -434,8 +432,11 @@ private static string VerifyVdfText(string loginUserPath)
         {
             var original = Globals.ReadAllText(loginUserPath);
             var vdf = original;
-            // Replaces double quotes, sometimes added by mistake (?) with single, as they should be.
-            vdf = vdf.Replace("\"\"", "\"");
+            //// Replaces double quotes, sometimes added by mistake (?) with single, as they should be.
+            //vdf = vdf.Replace("\"\"", "\"");
+
+            // Logic can be improved here. Currently the above causes issues, whereas before this was nessecary... Very flaky.
+
             if (original == vdf) return vdf;
 
             // Save original file if different.

TcNo-Acc-Switcher-Server/Platforms.json

@@ -421,7 +421,10 @@
       },
       "ExitBeforeInteract": true,
       "UniqueIdFile": "%AppData%\\Battle.net\\Battle.net.config::$.Client.SavedAccountNames",
-      "UniqueIdMethod": "JSON_SELECT_FIRST,"
+      "UniqueIdMethod": "JSON_SELECT_FIRST,",
+      "Extras": {
+        "ClosingMethod": "TaskKill"
+      }
     }
   },
   "Platform-WIP": {

TcNo-Acc-Switcher-Server/Resources/en-US.yml

@@ -241,6 +241,7 @@ Toast_SteamWebKeyInvalid: Steam Web API key seems to be invalid. Please set a ne
 Toast_DownloadingProfileData: Downloading profile data
 Toast_PasswordChanged: Password changed
 Toast_JsonFailModify: Failed to modify JSON file. See log.
+Toast_DifferentClosingMethod: "'Closing Method' is different to the default. If games are closing and more check if changing this option helps. Default: {defaultMethod}, Current: {currentMethod}"
 Modal_Crowdin_Header: Crowdin translators
 Modal_Crowdin_Info: "Here's everyone who helped translate this software.<br>Users with languages next to them helped a lot in translation (proofreader role)."
 Modal_Info_Creator: Created by TechNobo [Wesley Pyburn]