Further improve malformed .cue UX

YoshiRulz · YoshiRulz · commit c913c5a6e628 · 2024-09-14T04:59:38.000+10:00
see 8f963ba, #4013
diff --git a/src/BizHawk.Emulation.DiscSystem/DiscExtensions.cs b/src/BizHawk.Emulation.DiscSystem/DiscExtensions.cs
@@ -25,9 +25,10 @@ private static Disc CreateImpl(DiscType? type, string path, Action<string> error
 
 			if (discMountJob.OUT_ErrorLevel)
 			{
-				throw new Exception(string.IsNullOrEmpty(discMountJob.OUT_Log)
+				errorCallback(string.IsNullOrEmpty(discMountJob.OUT_Log)
 					? $"Could not process file \"{path}\"."
 					: $"Could not process file \"{path}\". Warnings/errors:\n{discMountJob.OUT_Log}\n(end disc load log)");
+				return discMountJob.OUT_Disc;
 			}
 
 			var disc = discMountJob.OUT_Disc;

Original file line number	Diff line number	Diff line change
`@@ -25,9 +25,10 @@ private static Disc CreateImpl(DiscType? type, string path, Action<string> error`
`25`	`25`
`26`	`26`	`if (discMountJob.OUT_ErrorLevel)`
`27`	`27`	`{`
`28`		`- throw new Exception(string.IsNullOrEmpty(discMountJob.OUT_Log)`
	`28`	`+ errorCallback(string.IsNullOrEmpty(discMountJob.OUT_Log)`
`29`	`29`	`? $"Could not process file \"{path}\"."`
`30`	`30`	`: $"Could not process file \"{path}\". Warnings/errors:\n{discMountJob.OUT_Log}\n(end disc load log)");`
	`31`	`+ return discMountJob.OUT_Disc;`
`31`	`32`	`}`
`32`	`33`
`33`	`34`	`var disc = discMountJob.OUT_Disc;`