Don't invoke UB with possibly unaligned memory

CasualPokePlayer · CasualPokePlayer · commit 245f0e227169 · 2024-09-11T16:26:00.000-07:00
diff --git a/src/BizHawk.Client.EmuHawk/RetroAchievements/RetroAchievements.GameVerification.cs b/src/BizHawk.Client.EmuHawk/RetroAchievements/RetroAchievements.GameVerification.cs
@@ -431,7 +431,8 @@ private bool GetNcchNormalKeysFunc(IntPtr primary_key_y, byte secondary_key_x_sl
 					return true;
 				}
 
-				var programId = MemoryMarshal.GetReference(Util.UnsafeSpanFromPointer<ulong>(ptr: optional_program_id, count: 1));
+				var programId = MemoryMarshal.Read<ulong>(
+					Util.UnsafeSpanFromPointer<byte>(ptr: optional_program_id, count: 8));
 
 				FirmwareID seeddbFWID = new("3DS", "seeddb");
 				using BinaryReader seeddb = new(GetFirmware(seeddbFWID));

Original file line number	Diff line number	Diff line change
`@@ -431,7 +431,8 @@ private bool GetNcchNormalKeysFunc(IntPtr primary_key_y, byte secondary_key_x_sl`
`431`	`431`	`return true;`
`432`	`432`	`}`
`433`	`433`
`434`		`- var programId = MemoryMarshal.GetReference(Util.UnsafeSpanFromPointer<ulong>(ptr: optional_program_id, count: 1));`
	`434`	`+ var programId = MemoryMarshal.Read<ulong>(`
	`435`	`+ Util.UnsafeSpanFromPointer<byte>(ptr: optional_program_id, count: 8));`
`435`	`436`
`436`	`437`	`FirmwareID seeddbFWID = new("3DS", "seeddb");`
`437`	`438`	`using BinaryReader seeddb = new(GetFirmware(seeddbFWID));`