Also print when LuaPictureBox.DrawIcon called with mismatched w/h

see #3851, 170d1a6

Author: YoshiRulz

src/BizHawk.Client.EmuHawk/tools/Lua/Libraries/FormsLuaLibrary.cs

@@ -535,9 +535,24 @@ public void DrawIcon(
 			try
 			{
 				var match = FindFormOrControlWithHandle(componentHandle);
-				if (match is LuaPictureBox control) control.DrawIcon(path, x: x, y: y, width: width, height: height);
-				else if (match is Form) LogOutputCallback(ERR_MSG_DRAW_ON_FORM);
-				else if (match is not null) LogOutputCallback(ERR_MSG_CONTROL_NOT_LPB);
+				if (match is LuaPictureBox control)
+				{
+					control.DrawIcon(
+						path: path,
+						x: x,
+						y: y,
+						width: width,
+						height: height,
+						functionName: "forms.drawIcon");
+				}
+				else if (match is Form)
+				{
+					LogOutputCallback(ERR_MSG_DRAW_ON_FORM);
+				}
+				else if (match is not null)
+				{
+					LogOutputCallback(ERR_MSG_CONTROL_NOT_LPB);
+				}
 			}
 			catch (Exception ex)
 			{

src/BizHawk.Client.EmuHawk/tools/Lua/LuaCanvas.cs

@@ -220,7 +220,13 @@ public void DrawIcon(string path, int x, int y, int? width = null, int? height =
 		{
 			try
 			{
-				luaPictureBox.DrawIcon(path, x, y, width, height);
+				luaPictureBox.DrawIcon(
+					path: path,
+					x: x,
+					y: y,
+					width: width,
+					height: height,
+					functionName: "(LuaCanvas).DrawIcon");
 			}
 			catch (Exception ex)
 			{

src/BizHawk.Client.EmuHawk/tools/Lua/LuaPictureBox.cs

@@ -145,15 +145,16 @@ public void DrawEllipse(
 			boxBackground.DrawEllipse(GetPen(TableHelper.SafeParseColor(line) ?? _defaultForeground), x, y, width, height);
 		}
 
-		public void DrawIcon(string path, int x, int y, int? width, int? height)
+		public void DrawIcon(string path, int x, int y, int? width, int? height, string functionName)
 		{
 			Icon icon;
-			if (width.HasValue && height.HasValue)
+			if (width is int w && height is int h)
 			{
-				icon = new Icon(path, width.Value, height.Value);
+				icon = new Icon(path, width: w, height: h);
 			}
 			else
 			{
+				if (width is not null || height is not null) WarnForMismatchedPair(functionName: functionName, kind: "width and height");
 				icon = new Icon(path);
 			}
 
@@ -409,5 +410,8 @@ protected override void OnClick(EventArgs e)
 			DoLuaClick(this, e);
 			base.OnClick(e);
 		}
+
+		private void WarnForMismatchedPair(string functionName, string kind)
+			=> LogOutputCallback($"{functionName}: both {kind} must be set to have any effect");
 	}
 }