Merge pull request #47 from SynergyWholesale/develop

v2.1.11

Author: Cameron Hall

CHANGELOG.md

@@ -15,6 +15,10 @@ Synergy Wholesale WHMCS Domains Module
 ### Removed
 -
 
+## 2.1.11 [Updated 29/10/2020]
+### Fixed
+- Fixed admin and billing contacts not being updatable. Fixes [#45](https://github.com/SynergyWholesale/WHMCS-Domains-Module/issues/45)
+
 ## 2.1.10 [Updated 09/10/2020]
 ### Fixed
 - Fixed transfer domain conditions incorrectly testing against the SLD and not the TLD.

README.md

@@ -4,7 +4,7 @@
 [![License: GPL v3](https://img.shields.io/badge/License-GPLv3-blue.svg)](LICENSE)
 [![Contributors welcome](https://img.shields.io/badge/Contributors-welcome-brightgreen.svg)](https://github.com/synergywholesale/whmcs-domains-module/blob/master/CONTRIBUTING.md)
 
-This repository contains the source code for the [Synergy Wholsale](https://synergywholesale.com/) WHMCS domains module.
+This repository contains the source code for the [Synergy Wholesale](https://synergywholesale.com/) WHMCS domains module.
 
 ## Features
 ---
@@ -47,4 +47,4 @@ This module utilises the **PHP SOAP** module. In order to connect to use our API
 If you are interested in contributing, and need some help getting started; please see our [contribution guide](CONTRIBUTING.md).
 
 # License
-This project is licensed under the GNU General Public License v3.0. See the [LICENSE](LICENSE) file for further information.
+This project is licensed under the GNU General Public License v3.0. See the [LICENSE](LICENSE) file for further information.

modules/registrars/synergywholesaledomains/synergywholesaledomains.php

@@ -1118,7 +1118,6 @@ function synergywholesaledomains_GetContactDetails(array $params)
     $idProtectStatus = synergywholesaledomains_apiRequest('domainInfo', $params, [], false);
     $command = ('Enabled' === $idProtectStatus['idProtect'] ? 'listProtectedContacts' : 'listContacts');
     $contacts = synergywholesaledomains_apiRequest($command, $params, [], false);
-
     $response = [];
 
     $map = [
@@ -1135,7 +1134,14 @@ function synergywholesaledomains_GetContactDetails(array $params)
         'email' => 'Email',
     ];
 
-    foreach (['registrant', 'tech', 'billing', 'admin'] as $contact) {
+    $contactTypes = ['registrant'];
+    foreach (['admin', 'billing', 'tech'] as $otherTypes) {
+        if (isset($contacts[$otherTypes])) {
+            $contactTypes[] = $otherTypes;
+        }
+    }
+
+    foreach ($contactTypes as $contact) {
         $whmcs_contact = ucfirst($contact);
         $response[$whmcs_contact] = [];
         foreach ($map as $from => $to) {