UUID and ULID support

[misaert]

Hi,

It seems the trait ResetPasswordRequestRepositoryTrait does not support UUID and ULID because with Doctrine, it must add 'ulid' as the third argument to tell Doctrine that this is a ULID or alternatively, you can convert it to a value compatible with the type inferred by Doctrine (see https://symfony.com/doc/current/components/uid.html#storing-ulids-in-databases).

I have to override 2 trait methods to do them work:

class ResetPasswordRequestRepository extends ServiceEntityRepository implements ResetPasswordRequestRepositoryInterface
{
    use ResetPasswordRequestRepositoryTrait;

    public function __construct(ManagerRegistry $registry)
    {
        parent::__construct($registry, ResetPasswordRequest::class);
    }

    /**
     * @param User $user
     */
    public function createResetPasswordRequest(
        object $user,
        DateTimeInterface $expiresAt,
        string $selector,
        string $hashedToken
    ): ResetPasswordRequestInterface {
        return new ResetPasswordRequest($user, $expiresAt, $selector, $hashedToken);
    }

    /**
     * Override trait method because of using ulid for user ID.
     *
     * @param User $user
     */
    public function getMostRecentNonExpiredRequestDate(object $user): ?DateTimeInterface
    {
        // Normally there is only 1 max request per use, but written to be flexible
        /** @var ResetPasswordRequestInterface $resetPasswordRequest */
        $resetPasswordRequest = $this->createQueryBuilder('t')
            ->where('t.user = :user')
            ->setParameter('user', $user->getId(), 'ulid')
            ->orderBy('t.requestedAt', 'DESC')
            ->setMaxResults(1)
            ->getQuery()
            ->getOneorNullResult()
        ;
        if (null !== $resetPasswordRequest && !$resetPasswordRequest->isExpired()) {
            return $resetPasswordRequest->getRequestedAt();
        }

        return null;
    }

    /**
     * Override trait method because of using ulid for user ID.
     */
    public function removeResetPasswordRequest(ResetPasswordRequestInterface $resetPasswordRequest): void
    {
        /** @var User $user */
        $user = $resetPasswordRequest->getUser();

        $this->createQueryBuilder('t')
            ->delete()
            ->where('t.user = :user')
            ->setParameter('user', $user->getId(), 'ulid')
            ->getQuery()
            ->execute()
        ;
    }
}

Did I have another solution?

Thanks a lot,

Mickaël

[pacproduct]

I'm facing this issue too. Adding the error I'm facing here, it might help others finding this thread:

An exception occurred while executing a query: SQLSTATE[22P02]: Invalid text representation: 7 ERROR: invalid input syntax for type uuid: "01G56C##############"

In the meantime, thanks @misaert for your workaround 👍

[DrLuke]

Tangentially related: The trait needs to check how many rows were affected, otherwise this just fails silently and the link is reusable until it's cleaned up!

[mindaugasvcs]

Still no updates on this issue? Who can add this code (composite primary keys excluded):

    $meta = $em->getClassMetadata(get_class($user));
    $identifier = PropertyAccess::createPropertyAccessor()->getValue($user, $meta->getSingleIdentifierFieldName());
    if ($identifier instanceof Ulid || $identifier instanceof Uuid) {
        $query->setParameter('user', $identifier->toBinary(), ParameterType::BINARY);
    } else {
        $query->setParameter('user', $user);
    }

[sadikoff]

Hey @mindaugasvcs

sooo if you know good way to fix it, you can propose a PR with the fix and it will be reviewed and merged if everything will be ok

Cheers!