feature #300 [interface] change generateResetToken()

Author: jrushlow

CHANGELOG.md

@@ -9,6 +9,7 @@ find a change that break's semver, please create an issue.*
 
 ### Feature
 
+- [#300](https://github.com/symfonycasts/reset-password-bundle/pull/300) - [interface] change `generateResetToken()` signature - *@jrushlow*
 - [#298](https://github.com/symfonycasts/reset-password-bundle/pull/298) - replace final annotation with final class keyword - *@jrushlow*
 
 ## [v1.18.0](https://github.com/symfonycasts/reset-password-bundle/releases/tag/v1.18.0)

UPGRADING.md

@@ -2,6 +2,16 @@
 
 ResetPasswordBundle now requires PHP `8.3`+ & Symfony `6.4.5`+
 
+## ResetPasswordHelperInterface
+
+- The `$resetRequestLifetime` argument for `generateResetToken()` must exist in 
+classes that implement the interface.
+
+```diff
+- public function generateResetToken(object $user/* , ?int $resetRequestLifetime = null */): ResetPasswordToken;
++ public function generateResetToken(object $user, ?int $resetRequestLifetime = null): ResetPasswordToken;
+```
+
 ## ResetPasswordHelper
 
 - Class became `@final` in `v1.22.0` and in `v2.0.0` the `@final` annotation was 

phpstan-baseline.neon

@@ -1,5 +1,3 @@
-includes:
-        - phpstan-baseline.neon
 parameters:
     level: 6
     bootstrapFiles:

phpstan.dist.neon

@@ -28,11 +28,11 @@ interface ResetPasswordHelperInterface
      * and removeResetRequest() can eventually invalidate it by removing it
      * from storage.
      *
-     * @param ?int $resetRequestLifetime Override the default (to be added to interface in 2.0)
+     * @param ?int $resetRequestLifetime Override the default lifetime
      *
      * @throws ResetPasswordExceptionInterface
      */
-    public function generateResetToken(object $user/* , ?int $resetRequestLifetime = null */): ResetPasswordToken;
+    public function generateResetToken(object $user, ?int $resetRequestLifetime = null): ResetPasswordToken;
 
     /**
      * Validate a reset request and fetch the user from persistence.