Skip to content

[Feature Request]: Hide Stirling PDF banners when on local install #3372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
Frooodle opened this issue Apr 17, 2025 · 5 comments · May be fixed by #3403
Open
1 task done

[Feature Request]: Hide Stirling PDF banners when on local install #3372

Frooodle opened this issue Apr 17, 2025 · 5 comments · May be fixed by #3403
Labels
enhancement New feature or request Front End Issues or pull requests related to front-end development

Comments

@Frooodle
Copy link
Member

Feature Description

Hide Stirling PDF banners when on local install

Image

Why is this feature valuable?

No response

Suggested Implementation

No response

Additional Information

No response

No Duplicate of the Feature

  • I have verified that there are no existing features requests similar to my request.
@Frooodle Frooodle added the enhancement New feature or request label Apr 17, 2025
@dosubot dosubot bot added the Front End Issues or pull requests related to front-end development label Apr 17, 2025
@muratcanyeldan
Copy link
Contributor

If it's okay, you can assign this task to me. Do we have any idea on how to detect whether it's a local installation? For example, are we planning to manage it through something like a Docker environment variable, or are we thinking of a structure where we simply hide it if it's running in a containerized environment?

@Frooodle
Copy link
Member Author

Frooodle commented Apr 20, 2025

So had a bit more thinking on this
These banners serve the same purpose of asking the user for consent on analytics,
the middle Modal is for server analytics and the bottom cookie consent is for web analytics.
The Server analytics is presented to the first user that connects as it assumes they are admin

I think for the first ever use we can do
If server analytics prompt is showing, then hide cookie consent analytics.
And whatever server analytics consent is selected (enable or disable) then the same is selected for the cookie consent, no need for this duplication of banners

@Frooodle
Copy link
Member Author

Frooodle commented Apr 20, 2025

Also fyi by local i misspoke i meant non server installation, which can be done by detecting the flag BROWSER_OPEN
But that's unrelated now since we should still ask for consent of these users

@muratcanyeldan
Copy link
Contributor

Okay thank you for explanation. I can work on this if it's okay

@Frooodle
Copy link
Member Author

Absolutely!

@ConnorYoh ConnorYoh marked this as a duplicate of #3396 Apr 22, 2025
@muratcanyeldan muratcanyeldan linked a pull request Apr 23, 2025 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Front End Issues or pull requests related to front-end development
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants