Merge pull request #76 from Sp3c1alK/smart

Accept "OK" in addition to "PASSED" as SMART result

Author: Starttoaster

Dockerfile

@@ -1,4 +1,4 @@
-FROM golang:1 as build
+FROM golang:1 AS build
 
 WORKDIR /go/src/app
 COPY . .

README.md

@@ -207,7 +207,7 @@ proxmox_node_days_until_cert_expiration{cluster="prd",node="cmp3",subject="/CN=P
 proxmox_node_days_until_cert_expiration{cluster="prd",node="cmp3",subject="/CN=cmp3.gentoo-yo.ts.net"} 76
 proxmox_node_days_until_cert_expiration{cluster="prd",node="cmp3",subject="/OU=PVE Cluster Node/O=Proxmox Virtual Environment/CN=cmp3.local"} 702
 
-# HELP proxmox_node_disk_smart_status Disk SMART health status. (0=FAIL/Unknown,1=PASSED)
+# HELP proxmox_node_disk_smart_status Disk SMART health status. (0=FAIL/Unknown,1=PASSED/OK)
 # TYPE proxmox_node_disk_smart_status gauge
 proxmox_node_disk_smart_status{cluster="prd",devpath="/dev/nvme0n1",node="cmp1"} 1
 proxmox_node_disk_smart_status{cluster="prd",devpath="/dev/nvme0n1",node="cmp2"} 1

internal/prometheus/node.go

@@ -114,7 +114,7 @@ func (c *Collector) collectDiskMetrics(ch chan<- prometheus.Metric, node proxmox
 	for _, disk := range disks.Data {
 		// Add disk health metric
 		status := 0.0
-		if strings.EqualFold(disk.Health, "PASSED") {
+		if strings.EqualFold(disk.Health, "PASSED") || strings.EqualFold(disk.Health, "OK") {
 			status = 1.0
 		}
 		ch <- prometheus.MustNewConstMetric(c.diskSmartHealth, prometheus.GaugeValue, status, node.Node, disk.DevPath)

internal/prometheus/prometheus.go

@@ -126,7 +126,7 @@ func NewCollector() *Collector {
 
 		// Disk metrics
 		diskSmartHealth: prometheus.NewDesc(fqAddPrefix("node_disk_smart_status"),
-			"Disk SMART health status. (0=FAIL/Unknown,1=PASSED)",
+			"Disk SMART health status. (0=FAIL/Unknown,1=PASSED/OK)",
 			[]string{"node", "devpath"},
 			constLabels,
 		),