Skip to content

Commit ae12d4f

Browse files
committed
correctly addressed underlying issue with extract phase, rolled back problematic fix
1 parent c312e97 commit ae12d4f

File tree

2 files changed

+10
-12
lines changed

2 files changed

+10
-12
lines changed

src/render/extract.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -377,27 +377,27 @@ pub fn extract(
377377

378378
pub fn extract_removal(
379379
mut commands: Commands,
380-
removed_tiles_query: Extract<Query<&RemovedTileEntity>>,
381-
removed_maps_query: Extract<Query<&RemovedMapEntity>>,
380+
removed_tiles_query: Extract<Query<(Entity, &RemovedTileEntity)>>,
381+
removed_maps_query: Extract<Query<(Entity, &RemovedMapEntity)>>,
382382
) {
383383
let mut removed_tiles: Vec<(Entity, ExtractedRemovedTileBundle)> = Vec::new();
384-
for entity in removed_tiles_query.iter() {
384+
for (entity, removed) in removed_tiles_query.iter() {
385385
removed_tiles.push((
386-
entity.0,
386+
entity,
387387
ExtractedRemovedTileBundle {
388-
tile: ExtractedRemovedTile { entity: entity.0 },
388+
tile: ExtractedRemovedTile { entity: removed.0 },
389389
},
390390
));
391391
}
392392

393393
commands.insert_or_spawn_batch(removed_tiles);
394394

395395
let mut removed_maps: Vec<(Entity, ExtractedRemovedMapBundle)> = Vec::new();
396-
for entity in removed_maps_query.iter() {
396+
for (entity, removed) in removed_maps_query.iter() {
397397
removed_maps.push((
398-
entity.0,
398+
entity,
399399
ExtractedRemovedMapBundle {
400-
map: ExtractedRemovedMap { entity: entity.0 },
400+
map: ExtractedRemovedMap { entity: removed.0 },
401401
},
402402
));
403403
}

src/render/mod.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -309,20 +309,18 @@ pub struct RemovedMapEntity(pub Entity);
309309

310310
fn removal_helper(
311311
mut commands: Commands,
312-
entities: &Entities,
313312
mut removed_query: RemovedComponents<TilePos>,
314313
) {
315-
for entity in removed_query.read().filter(|entity| entities.contains(*entity)) {
314+
for entity in removed_query.read() {
316315
commands.spawn(RemovedTileEntity(entity));
317316
}
318317
}
319318

320319
fn removal_helper_tilemap(
321320
mut commands: Commands,
322-
entities: &Entities,
323321
mut removed_query: RemovedComponents<TileStorage>,
324322
) {
325-
for entity in removed_query.read().filter(|entity| entities.contains(*entity)) {
323+
for entity in removed_query.read() {
326324
commands.spawn(RemovedMapEntity(entity));
327325
}
328326
}

0 commit comments

Comments
 (0)