Skip to content

Commit 92fc406

Browse files
authored
Merge pull request #510 from thebluefish/main
Filter RemovedComponents for entities that no longer exist
2 parents b08a5d9 + 16cf328 commit 92fc406

File tree

3 files changed

+10
-10
lines changed

3 files changed

+10
-10
lines changed

src/render/extract.rs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -377,27 +377,27 @@ pub fn extract(
377377

378378
pub fn extract_removal(
379379
mut commands: Commands,
380-
removed_tiles_query: Extract<Query<&RemovedTileEntity>>,
381-
removed_maps_query: Extract<Query<&RemovedMapEntity>>,
380+
removed_tiles_query: Extract<Query<(Entity, &RemovedTileEntity)>>,
381+
removed_maps_query: Extract<Query<(Entity, &RemovedMapEntity)>>,
382382
) {
383383
let mut removed_tiles: Vec<(Entity, ExtractedRemovedTileBundle)> = Vec::new();
384-
for entity in removed_tiles_query.iter() {
384+
for (entity, removed) in removed_tiles_query.iter() {
385385
removed_tiles.push((
386-
entity.0,
386+
entity,
387387
ExtractedRemovedTileBundle {
388-
tile: ExtractedRemovedTile { entity: entity.0 },
388+
tile: ExtractedRemovedTile { entity: removed.0 },
389389
},
390390
));
391391
}
392392

393393
commands.insert_or_spawn_batch(removed_tiles);
394394

395395
let mut removed_maps: Vec<(Entity, ExtractedRemovedMapBundle)> = Vec::new();
396-
for entity in removed_maps_query.iter() {
396+
for (entity, removed) in removed_maps_query.iter() {
397397
removed_maps.push((
398-
entity.0,
398+
entity,
399399
ExtractedRemovedMapBundle {
400-
map: ExtractedRemovedMap { entity: entity.0 },
400+
map: ExtractedRemovedMap { entity: removed.0 },
401401
},
402402
));
403403
}

src/render/mod.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ impl Plugin for TilemapRenderingPlugin {
116116
app.add_systems(Update, set_texture_to_copy_src);
117117

118118
app.add_systems(First, clear_removed);
119-
app.add_systems(PostUpdate, (removal_helper_tilemap, removal_helper));
119+
app.add_systems(PostUpdate, (removal_helper, removal_helper_tilemap));
120120

121121
app.add_plugins(MaterialTilemapPlugin::<StandardTilemapMaterial>::default());
122122

src/render/texture_array_cache.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ impl TextureArrayCache {
8686
"Expected image to have finished loading if \
8787
it is being extracted as a texture!",
8888
);
89-
let this_tile_size: TilemapTileSize = image.size_f32().try_into().unwrap();
89+
let this_tile_size: TilemapTileSize = image.size_f32().into();
9090
if this_tile_size != tile_size {
9191
panic!(
9292
"Expected all provided image assets to have size {tile_size:?}, \

0 commit comments

Comments
 (0)