Skip to content

Commit f5cb0df

Browse files
committed
Clean up temporary patches after fix for py3 venv identified
1 parent 3ba0975 commit f5cb0df

File tree

1 file changed

+1
-11
lines changed

1 file changed

+1
-11
lines changed

Makefile

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ check-python-packages:
228228
@echo ""
229229
@echo "================== CHECK PYTHON PACKAGES ===================="
230230
@echo ""
231-
test -f $(VIRTUALENV_COMPONENTS_DIR)/bin/activate || $(PYTHON_VERSION) -m venv $(VIRTUALENV_COMPONENTS_DIR) || virtualenv --python=$(PYTHON_VERSION) $(VIRTUALENV_COMPONENTS_DIR) --no-download
231+
test -f $(VIRTUALENV_COMPONENTS_DIR)/bin/activate || virtualenv --python=$(PYTHON_VERSION) $(VIRTUALENV_ST2CLIENT_DIR) --no-download --system-site-packages
232232
@for component in $(COMPONENTS_WITHOUT_ST2TESTS); do \
233233
echo "==========================================================="; \
234234
echo "Checking component:" $$component; \
@@ -396,16 +396,6 @@ flake8: requirements .flake8
396396
$(VIRTUALENV_ST2CLIENT_DIR)/bin/pip install --upgrade "pip==$(PIP_VERSION)"
397397
$(VIRTUALENV_ST2CLIENT_DIR)/bin/pip install --upgrade "setuptools==44.1.0"
398398

399-
#if [[ $(PYTHON_VERSION) == *"python2.7"* ]]; then \
400-
# echo 'Upgrading pip==$(PIP_VERSION) in python2.7 virtualenv'; \
401-
# $(VIRTUALENV_ST2CLIENT_DIR)/bin/pip install --upgrade "pip==$(PIP_VERSION)"; \
402-
# $(VIRTUALENV_ST2CLIENT_DIR)/bin/pip install --upgrade "setuptools==44.1.0"; \
403-
#else \
404-
# echo 'Upgrading pip==$(PIP_VERSION) in python3.x virtualenv'; \
405-
# $(VIRTUALENV_ST2CLIENT_DIR)/bin/python -m pip install --upgrade "pip==$(PIP_VERSION)"; \
406-
# $(VIRTUALENV_ST2CLIENT_DIR)/bin/python -m pip install --upgrade "setuptools==44.1.0"; \
407-
#fi
408-
409399
$(VIRTUALENV_ST2CLIENT_DIR)/bin/activate; cd st2client ; ../$(VIRTUALENV_ST2CLIENT_DIR)/bin/python setup.py install ; cd ..
410400
$(VIRTUALENV_ST2CLIENT_DIR)/bin/st2 --version
411401
$(VIRTUALENV_ST2CLIENT_DIR)/bin/python -c "import st2client"

0 commit comments

Comments
 (0)