Remove tweens used in scroll_to() function #58
HaroldLever
started this conversation in
Ideas
Replies: 1 comment
-
Generally, I agree that moving from tweens to adding velocity is a good idea.
For that, we could add a parameter with default value where the user can specify which
I think this drawback is worth it. If there is demand on bringing that |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I happened to find that
scroll_horizontal
andscroll_vertical
didn't kill tweens used in scroll_to() function properly. I was intending to create a new pull request, then I realized maybe we shouldn't use tweens, but should apply the exact velocity to make content scroll to destination. Future developers will no longer need to think about when to kill tweens.I have some worries if we apply a velocity instead of using tween. When
wheel_scroll_damper
anddragging_scroll_damper
are different, scroll_to() behavior will present differently. Also, scroll_to() will remove the parameterduration
since we can't control it, which seems to be a "downgrade" and more importantly, it's not a compatible change.I want to hear your idea on this topic, which solution should we take and is there any better thoughts?
Beta Was this translation helpful? Give feedback.
All reactions