[Test] Fix bug

- Add file closing in test_utils._read_matrix()
- Remove extra slash at the beginning of matrix paths

Author: Krekep

python/tests/test_duplicate.py

@@ -7,7 +7,7 @@ def test_duplicate(self):
         """
         Unit test for duplicate of matrix
         """
-        first_matrix = test_utils.build_matrix_from_file("/matrices/duplicate.txt")
+        first_matrix = test_utils.build_matrix_from_file("matrices/duplicate.txt")
 
         actual_matrix = first_matrix.dup()
 

python/tests/test_extract_matrix.py

@@ -7,8 +7,8 @@ def test_extract_matrix(self):
         """
         Unit test for extract submatrix from left-upper corner of matrix
         """
-        first_matrix = test_utils.build_matrix_from_file("/matrices/extract_matrix.txt")
-        expected_matrix = test_utils.build_matrix_from_file("/matrices/extract_matrix_result.txt")
+        first_matrix = test_utils.build_matrix_from_file("matrices/extract_matrix.txt")
+        expected_matrix = test_utils.build_matrix_from_file("matrices/extract_matrix_result.txt")
 
         actual_matrix = first_matrix.extract_matrix(0, 0, expected_matrix.shape)
 

python/tests/test_kronecker.py

@@ -7,11 +7,11 @@ def test_kronecker(self):
         """
         Unit test for kronecker product of two matrices
         """
-        first_matrix = test_utils.build_matrix_from_file("/matrices/kronecker_4.txt")
-        second_matrix = test_utils.build_matrix_from_file("/matrices/kronecker_5.txt")
+        first_matrix = test_utils.build_matrix_from_file("matrices/kronecker_4.txt")
+        second_matrix = test_utils.build_matrix_from_file("matrices/kronecker_5.txt")
 
         actual_matrix = first_matrix.kronecker(second_matrix)
-        expected_matrix = test_utils.build_matrix_from_file("/matrices/kronecker_result.txt")
+        expected_matrix = test_utils.build_matrix_from_file("matrices/kronecker_result.txt")
 
         self.assertTrue(test_utils.compare_matrix(expected_matrix, actual_matrix))
 

python/tests/test_matrix_add.py

@@ -7,11 +7,11 @@ def test_add(self):
         """
         Unit test for addition of two matrices
         """
-        first_matrix = test_utils.build_matrix_from_file("/matrices/add_1.txt")
-        second_matrix = test_utils.build_matrix_from_file("/matrices/add_2.txt")
+        first_matrix = test_utils.build_matrix_from_file("matrices/add_1.txt")
+        second_matrix = test_utils.build_matrix_from_file("matrices/add_2.txt")
 
         actual_matrix = first_matrix.ewiseadd(second_matrix)
-        expected_matrix = test_utils.build_matrix_from_file("/matrices/add_result.txt")
+        expected_matrix = test_utils.build_matrix_from_file("matrices/add_result.txt")
 
         self.assertTrue(test_utils.compare_matrix(expected_matrix, actual_matrix))
 

python/tests/test_matrix_mxm.py

@@ -7,11 +7,11 @@ def test_mxm(self):
         """
         Unit test for multiplication of two matrices
         """
-        first_matrix = test_utils.build_matrix_from_file("/matrices/mxm_1.txt")
-        second_matrix = test_utils.build_matrix_from_file("/matrices/mxm_2.txt")
+        first_matrix = test_utils.build_matrix_from_file("matrices/mxm_1.txt")
+        second_matrix = test_utils.build_matrix_from_file("matrices/mxm_2.txt")
 
         actual_matrix = first_matrix.mxm(second_matrix)
-        expected_matrix = test_utils.build_matrix_from_file("/matrices/mxm_result.txt")
+        expected_matrix = test_utils.build_matrix_from_file("matrices/mxm_result.txt")
 
         self.assertTrue(test_utils.compare_matrix(expected_matrix, actual_matrix))
 

python/tests/test_matrix_properties.py

@@ -5,7 +5,7 @@
 class TestMatrixMethods(unittest.TestCase):
 
     def setUp(self) -> None:
-        self.matrix = test_utils.build_matrix_from_file("/matrices/property.txt")
+        self.matrix = test_utils.build_matrix_from_file("matrices/property.txt")
         self.result_property = list()
         with open("/matrices/property_result.txt", 'r') as _file:
             line = list(map(int, _file.readline().split()))

python/tests/test_reduce.py

@@ -7,10 +7,10 @@ def test_reduce(self):
         """
         Unit test for reduce of matrix
         """
-        first_matrix = test_utils.build_matrix_from_file("/matrices/reduce.txt")
+        first_matrix = test_utils.build_matrix_from_file("matrices/reduce.txt")
 
         actual_matrix = first_matrix.reduce()
-        expected_matrix = test_utils.build_matrix_from_file("/matrices/reduce_result.txt")
+        expected_matrix = test_utils.build_matrix_from_file("matrices/reduce_result.txt")
 
         self.assertTrue(test_utils.compare_matrix(expected_matrix, actual_matrix))
 

python/tests/test_to_lists.py

@@ -4,9 +4,9 @@
 
 class TestMatrixToLists(unittest.TestCase):
     def setUp(self) -> None:
-        self.matrix = test_utils.build_matrix_from_file("/matrices/to_lists.txt")
+        self.matrix = test_utils.build_matrix_from_file("matrices/to_lists.txt")
         self.result_lists = list()
-        with open("/matrices/to_lists_result.txt", 'r') as _file:
+        with open("matrices/to_lists_result.txt", 'r') as _file:
             line = list(map(int, _file.readline().split()))
             self.result_lists.append(line)
 

python/tests/test_transpose.py

@@ -7,10 +7,10 @@ def test_transpose(self):
         """
         Unit test for transpose of matrix
         """
-        first_matrix = test_utils.build_matrix_from_file("/matrices/transpose.txt")
+        first_matrix = test_utils.build_matrix_from_file("matrices/transpose.txt")
 
         actual_matrix = first_matrix.transpose()
-        expected_matrix = test_utils.build_matrix_from_file("/matrices/transpose_result.txt")
+        expected_matrix = test_utils.build_matrix_from_file("matrices/transpose_result.txt")
 
         self.assertTrue(test_utils.compare_matrix(expected_matrix, actual_matrix))
 

python/tests/test_utils.py

@@ -5,11 +5,10 @@ def _read_matrix(path: str):
     """
     Read matrix from file
     """
-
-    file = open(path, "r")
-    n, m = map(int, file.readline().split())
-    rows = list(map(int, file.readline().split()))
-    cols = list(map(int, file.readline().split()))
+    with open(path, 'r') as file:
+        n, m = map(int, file.readline().split())
+        rows = list(map(int, file.readline().split()))
+        cols = list(map(int, file.readline().split()))
     return n, m, [rows, cols]