JS-916 Remove logic related to SonarSec (#5872)

Co-authored-by: Karim El Ouerghemmi <karim.ouerghemmi@sonarsource.com>

Author: vdiez

.cirrus.template.yml

@@ -377,8 +377,8 @@ plugin_qa_fast_without_node_task:
   <<: *PLUGIN_QA_FAST_BODY
   env:
     # EslintCustomRulesTest requires Node.js in host OS
-    MVN_TEST: '-Dtest=!EslintCustomRulesTest'
-    IGNORE_CLASSES: '--projects !org.sonarsource.javascript:eslint-custom-rules-plugin'
+    MVN_TEST: '-Dtest=!EslintCustomRulesTest,!EslintCustomRulesLegacyTest'
+    IGNORE_CLASSES: '--projects !org.sonarsource.javascript:eslint-custom-rules-plugin,!org.sonarsource.javascript:eslint-custom-rules-plugin-legacy'
   matrix:
     - name: 'Fast QA without node on host Ubuntu SQ:LATEST'
       <<: *CONTAINER_DEFINITION

.cirrus.yml

@@ -0,0 +1,143 @@
+/*
+ * SonarQube JavaScript Plugin
+ * Copyright (C) 2012-2025 SonarSource SA
+ * mailto:info AT sonarsource DOT com
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the Sonar Source-Available License Version 1, as published by SonarSource SA.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+ * See the Sonar Source-Available License for more details.
+ *
+ * You should have received a copy of the Sonar Source-Available License
+ * along with this program; if not, see https://sonarsource.com/license/ssal/
+ */
+package com.sonar.javascript.it.plugin;
+
+import static com.sonarsource.scanner.integrationtester.utility.QualityProfileLoader.loadActiveRulesFromXmlProfile;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import com.sonarsource.scanner.integrationtester.dsl.EngineVersion;
+import com.sonarsource.scanner.integrationtester.dsl.Log;
+import com.sonarsource.scanner.integrationtester.dsl.ScannerInput;
+import com.sonarsource.scanner.integrationtester.dsl.ScannerOutputReader;
+import com.sonarsource.scanner.integrationtester.dsl.SonarServerContext;
+import com.sonarsource.scanner.integrationtester.runner.ScannerRunner;
+import java.io.File;
+import java.nio.file.Path;
+import org.assertj.core.groups.Tuple;
+import org.junit.jupiter.api.Test;
+import org.sonar.plugins.javascript.JavaScriptLanguage;
+import org.sonar.plugins.javascript.TypeScriptLanguage;
+import shadow.com.sonar.orchestrator.locator.FileLocation;
+
+class EslintCustomRulesLegacyTest {
+
+  private static final String PLUGIN_ARTIFACT_ID = "eslint-custom-rules-plugin-legacy";
+
+  private static final SonarServerContext SERVER_CONTEXT = SonarServerContext.builder()
+    .withProduct(SonarServerContext.Product.SERVER)
+    .withEngineVersion(EngineVersion.latestMasterBuild())
+    .withPlugin(SonarScannerIntegrationHelper.getJavascriptPlugin())
+    .withPlugin(
+      FileLocation.byWildcardMavenFilename(
+        new File("../plugins/" + PLUGIN_ARTIFACT_ID + "/target"),
+        PLUGIN_ARTIFACT_ID + "-*.jar"
+      )
+    )
+    .withLanguage(
+      JavaScriptLanguage.KEY,
+      "JAVASCRIPT",
+      JavaScriptLanguage.FILE_SUFFIXES_KEY,
+      JavaScriptLanguage.DEFAULT_FILE_SUFFIXES
+    )
+    .withLanguage(
+      TypeScriptLanguage.KEY,
+      "TYPESCRIPT",
+      TypeScriptLanguage.FILE_SUFFIXES_KEY,
+      TypeScriptLanguage.DEFAULT_FILE_SUFFIXES
+    )
+    .withActiveRules(
+      loadActiveRulesFromXmlProfile(
+        Path.of("src", "test", "resources", "profile-javascript-custom-rules-legacy.xml")
+      )
+    )
+    .withActiveRules(
+      loadActiveRulesFromXmlProfile(
+        Path.of("src", "test", "resources", "profile-typescript-custom-rules-legacy.xml")
+      )
+    )
+    .build();
+
+  @Test
+  void test() {
+    var build = ScannerInput.create("custom-rules", TestUtils.projectDirNoCopy("custom_rules"))
+      .withVerbose()
+      .withScmDisabled()
+      .withSourceDirs("src")
+      .build();
+    var result = ScannerRunner.run(SERVER_CONTEXT, build);
+    assertThat(result.logOutput())
+      .filteredOn(
+        l ->
+          l.level().equals(Log.Level.DEBUG) &&
+          l
+            .message()
+            .matches(
+              "Deploying custom rules bundle jar:file:.*/custom-eslint-based-rules-1\\.0\\.0\\.tgz to .*"
+            )
+      )
+      .hasSize(1);
+
+    assertThat(result.logOutput())
+      .filteredOn(
+        l -> l.level().equals(Log.Level.INFO) && l.message().contains("Work dir received:")
+      )
+      .hasSize(2);
+    assertThat(result.logOutput())
+      .filteredOn(l -> l.message().contains("Rule context options:"))
+      .hasSize(2);
+
+    var issues = result
+      .scannerOutputReader()
+      .getProject()
+      .getAllIssues()
+      .stream()
+      .filter(ScannerOutputReader.TextRangeIssue.class::isInstance)
+      .map(ScannerOutputReader.TextRangeIssue.class::cast)
+      .toList();
+    var eslintCustomRuleIssues = issues
+      .stream()
+      .filter(issue -> issue.ruleKey().equals("eslint-custom-rules:sqKey"))
+      .toList();
+
+    assertThat(eslintCustomRuleIssues).hasSize(2);
+    assertThat(eslintCustomRuleIssues)
+      .extracting(
+        ScannerOutputReader.TextRangeIssue::ruleKey,
+        ScannerOutputReader.TextRangeIssue::componentPath,
+        ScannerOutputReader.TextRangeIssue::line,
+        ScannerOutputReader.TextRangeIssue::message
+      )
+      .containsExactlyInAnyOrder(
+        new Tuple("eslint-custom-rules:sqKey", "src/dir/Person.js", 21, "call"),
+        new Tuple("eslint-custom-rules:sqKey", "src/dir/file.ts", 4, "call")
+      );
+    var tsEslintCustomRuleIssues = issues
+      .stream()
+      .filter(issue -> issue.ruleKey().equals("ts-custom-rules:tsRuleKey"))
+      .toList();
+    assertThat(tsEslintCustomRuleIssues)
+      .extracting(
+        ScannerOutputReader.TextRangeIssue::ruleKey,
+        ScannerOutputReader.TextRangeIssue::componentPath,
+        ScannerOutputReader.TextRangeIssue::line,
+        ScannerOutputReader.TextRangeIssue::message
+      )
+      .containsExactlyInAnyOrder(
+        new Tuple("ts-custom-rules:tsRuleKey", "src/dir/file.ts", 4, "tsrule call")
+      );
+  }
+}

its/plugin/fast-tests/src/test/java/com/sonar/javascript/it/plugin/EslintCustomRulesLegacyTest.java

@@ -110,10 +110,10 @@ void test() {
       .toList();
     var eslintCustomRuleIssues = issues
       .stream()
-      .filter(issue -> issue.ruleKey().equals("eslint-custom-rules:sqKey"))
+      .filter(issue -> issue.ruleKey().equals("js-custom-rules:jsRuleKey"))
       .toList();
 
-    assertThat(eslintCustomRuleIssues).hasSize(2);
+    assertThat(eslintCustomRuleIssues).hasSize(1);
     assertThat(eslintCustomRuleIssues)
       .extracting(
         ScannerOutputReader.TextRangeIssue::ruleKey,
@@ -122,8 +122,7 @@ void test() {
         ScannerOutputReader.TextRangeIssue::message
       )
       .containsExactlyInAnyOrder(
-        new Tuple("eslint-custom-rules:sqKey", "src/dir/Person.js", 21, "call"),
-        new Tuple("eslint-custom-rules:sqKey", "src/dir/file.ts", 4, "call")
+        new Tuple("js-custom-rules:jsRuleKey", "src/dir/Person.js", 21, "jsRuleKey call")
       );
     var tsEslintCustomRuleIssues = issues
       .stream()
@@ -137,7 +136,7 @@ void test() {
         ScannerOutputReader.TextRangeIssue::message
       )
       .containsExactlyInAnyOrder(
-        new Tuple("ts-custom-rules:tsRuleKey", "src/dir/file.ts", 4, "tsrule call")
+        new Tuple("ts-custom-rules:tsRuleKey", "src/dir/file.ts", 4, "tsRuleKey call")
       );
   }
 }

its/plugin/fast-tests/src/test/java/com/sonar/javascript/it/plugin/EslintCustomRulesTest.java

@@ -46,18 +46,6 @@ public static MavenLocation getHtmlPlugin() {
     return MavenLocation.of("org.sonarsource.html", "sonar-html-plugin", "LATEST_RELEASE");
   }
 
-  public static MavenLocation getSecurityPlugin() {
-    return MavenLocation.of("com.sonarsource.security", "sonar-security-plugin", "LATEST_RELEASE");
-  }
-
-  public static MavenLocation getSecurityJsFrontendPlugin() {
-    return MavenLocation.of(
-      "com.sonarsource.security",
-      "sonar-security-js-frontend-plugin",
-      "LATEST_RELEASE"
-    );
-  }
-
   public static MavenLocation getLitsPlugin() {
     return MavenLocation.of("org.sonarsource.sonar-lits-plugin", "sonar-lits-plugin", LITS_VERSION);
   }

its/plugin/fast-tests/src/test/java/com/sonar/javascript/it/plugin/HtmlSecurityTest.java

@@ -133,8 +133,4 @@ public static void copyFile(Path sourceFile, Path targetDirectory) {
       throw new UncheckedIOException(e);
     }
   }
-
-  public static boolean isUcfgFile(Path path, BasicFileAttributes attrs) {
-    return attrs.isRegularFile() && path.getFileName().toString().endsWith(".ucfgs");
-  }
 }