Skip to content

Commit 5cc5854

Browse files
committed
bump to node 24
1 parent dc98990 commit 5cc5854

File tree

5 files changed

+13
-39
lines changed

5 files changed

+13
-39
lines changed

.cirrus.template.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ node_recommended_container_definition: &NODE_RECOMMENDED_CONTAINER_DEFINITION
5050
<<: *NODE_MIN_SUPPORTED_CONTAINER_DEFINITION
5151
eks_container:
5252
docker_arguments:
53-
NODE_VERSION: 22.11.0
53+
NODE_VERSION: 24.0.0
5454

5555
node16_container_definition: &NODE16_CONTAINER_DEFINITION
5656
<<: *NODE_MIN_SUPPORTED_CONTAINER_DEFINITION

.cirrus.yml

Lines changed: 9 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package-lock.json

Lines changed: 2 additions & 21 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@
5757
},
5858
"homepage": "https://github.com/SonarSource/SonarJS#readme",
5959
"engines": {
60-
"node": "^20.12.0 || >=22.11.0"
60+
"node": "^20.12.0 || ^22.11.0 || ^24.0.0"
6161
},
6262
"type": "module",
6363
"devDependencies": {

sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S4123.html

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -37,21 +37,6 @@ <h2>Why is this an issue?</h2>
3737
await foo(); // Compliant
3838
}
3939
</pre>
40-
<h3>Exceptions</h3>
41-
<p>The rule does not raise issues if you are awaiting a function whose definition contains JSdoc with <code>@returns</code> or <code>@return</code>
42-
tags. This is due to JSdoc often mistakenly declaring a returning type without mentioning that it is resolved by a promise. For example:</p>
43-
<pre>
44-
async function foo () {
45-
await bar(); // Compliant
46-
}
47-
48-
/**
49-
* @return {number}
50-
*/
51-
async function bar () {
52-
return 42;
53-
}
54-
</pre>
5540
<h2>Resources</h2>
5641
<h3>Documentation</h3>
5742
<ul>

0 commit comments

Comments
 (0)