TooManyStatementsPerLine for lambdas

[Nekto89]

Describe the bug
TooManyStatementsPerLine is shown for one-line short lambdas which I find strange.

To Reproduce
Analyze code that contains lambdas.
Examples:
const auto get_value = [](const auto& element) noexcept { return element.second; };
std::for_each(files.begin(), files.end(), [&](const auto& i_file) { new_files.AddFile(i_file); });

Expected behavior
In my opinion there should be no "cxx:TooManyStatementsPerLine" code smells in such cases.

Screenshots

Desktop (please complete the following information):

• OS: Windows
• SonarQube version: 9.9.8
• cxx plugin version: 2.1.3.851
• sonar-scanner version: 5.0.1.3006

[guwirth]

Hi @Nekto89,

easy workaround would be (looks also much more readable):

const auto get_value = [](const auto& element) noexcept {
   return element.second;
};
std::for_each(files.begin(), files.end(), [&](const auto& i_file) {
   new_files.AddFile(i_file);
});

The check is implemented here, maybe you can have a look to it:

sonar-cxx/cxx-checks/src/main/java/org/sonar/cxx/checks/metrics/TooManyStatementsPerLineCheck.java

Line 44 in a65a14d

public class TooManyStatementsPerLineCheck extends AbstractOneStatementPerLineCheck<Grammar> {

sonar-cxx/cxx-squid-bridge/src/main/java/org/sonar/cxx/squidbridge/checks/AbstractOneStatementPerLineCheck.java

Line 33 in a65a14d

public abstract class AbstractOneStatementPerLineCheck<G extends Grammar> extends SquidCheck<G> {

In the SSLR toolkit you can narrow it down. Maybe should only check inside statementSeq?

Regards,

[guwirth]

How SonarSource is implementing this https://rules.sonarsource.com/cpp/RSPEC-122/

[guwirth]

cxx unit test
https://github.com/SonarOpenCommunity/sonar-cxx/blob/master/cxx-checks/src/test/java/org/sonar/cxx/checks/metrics/TooManyStatementsPerLineCheckTest.java
test file
https://github.com/SonarOpenCommunity/sonar-cxx/blob/master/cxx-checks/src/test/resources/checks/TooManyStatementsPerLine.cc