Skip to content

Commit 2016aed

Browse files
committed
promote isDevMode at utils
1 parent 81328ba commit 2016aed

File tree

2 files changed

+13
-5
lines changed

2 files changed

+13
-5
lines changed

build/utils.js

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
function isDevMode(mode) {
2+
return mode === "development"
3+
}
4+
exports.isDevMode = isDevMode;
5+
exports.getMode = function (env) {
6+
env = env || {};
7+
return env.mode || 'production'
8+
}
19
exports.pages = function (mode, folder = '') {
210
const rootPagesFolderName = 'pages'
311
const HtmlWebpackPlugin = require('html-webpack-plugin')
@@ -14,13 +22,13 @@ exports.pages = function (mode, folder = '') {
1422
const viewName = view.split('.')[0]
1523
const fileName = folder === '' ? `${viewName}/index.html` : `${folder}/${viewName}/index.html`
1624
const options = {
17-
minify: !mode === 'development',
25+
minify: !isDevMode(mode),
1826
filename: fileName,
1927
template: `views/${rootPagesFolderName}/${folder}/${view}`,
2028
inject: true
2129
}
2230

23-
if (mode === 'development') {
31+
if (isDevMode(mode)) {
2432
options.minify = {
2533
removeComments: true,
2634
collapseWhitespace: true,

build/webpack.config.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ module.exports = (env) => {
6565
{
6666
test: /\.css$/,
6767
use: [
68-
MODE === 'development' ? 'style-loader' : MiniCssExtractPlugin.loader,
68+
utils.isDevMode(MODE) ? 'style-loader' : MiniCssExtractPlugin.loader,
6969
{
7070
loader: 'css-loader',
7171
options: {
@@ -78,7 +78,7 @@ module.exports = (env) => {
7878
{
7979
test: /\.scss$/,
8080
use: [
81-
MODE === 'development' ? 'style-loader' : MiniCssExtractPlugin.loader, // creates style nodes from JS strings
81+
utils.isDevMode(MODE) ? 'style-loader' : MiniCssExtractPlugin.loader, // creates style nodes from JS strings
8282
{ loader: 'css-loader', options: { importLoaders: 1, sourceMap: true } }, // translates CSS into CommonJS
8383
'postcss-loader',
8484
'sass-loader', // compiles Sass to CSS
@@ -163,7 +163,7 @@ module.exports = (env) => {
163163

164164
// Homepage
165165
new HtmlWebpackPlugin({
166-
minify: !MODE === 'development',
166+
minify: !utils.isDevMode(MODE),
167167
filename: 'index.html',
168168
template: 'views/index.pug',
169169
inject: 'body',

0 commit comments

Comments
 (0)