Fix manual install instructions #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following is needed, git submodule update --init --recursive
sfc-gh-mslot
reviewed
Nov 5, 2025
Collaborator
sfc-gh-mslot
left a comment
sfc-gh-mslot
left a comment
There was a problem hiding this comment.
Thanks for trying it out!
| cd pg_lake/duckdb_pglake && make && make install && \ | ||
| cd pg_lake && \ | ||
| git submodule update --init --recursive && \ | ||
| cd duckdb_pglake && make && make install && \ |
Collaborator
There was a problem hiding this comment.
@sfc-gh-abozkurt can we remove this line? The top-level Makefile does the git submodule and also goes into duckdb_pglake.
Collaborator
There was a problem hiding this comment.
That PR can be closed when we merge #12 , which improves the make targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wow -- what a project! Excited to toy with it, but I needed to adjust some things to get it going.
The following is needed,
git submodule update --init --recursive
alternatively we can say something like enable the global git config setting:
git config --global submodule.recurse true