Upgrade to DuckDB 1.4.1 #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| query = "SELECT blob_col FROM duckdb_supported_types_table WHERE blob_col IS NOT NULL ORDER BY blob_col" | ||
| expected = [("\\x00",), ("\\x",), ("\\xdeadbeaf",)] | ||
| expected = [("\\x",), ("\\x00",), ("\\xdeadbeaf",)] |
Collaborator
Author
There was a problem hiding this comment.
The upgrade to duckdb seems to have changed the sort order of the 0-length byte NULL.
| const char *createGCSSecret = | ||
| "CREATE SECRET gcsdefault (" | ||
| "TYPE GCS, PROVIDER CREDENTIAL_CHAIN, " | ||
| "VALIDATION 'none', " |
Collaborator
There was a problem hiding this comment.
why do we need that?
Collaborator
Author
There was a problem hiding this comment.
If you don't have this, the updated secrets interface will complain in DuckDB 1.4.0+, which prevents pgduck_server from starting due to not necessarily having ~/.aws/config defined. This just suppresses the checks when it initializes.
sfc-gh-dachristensen
force-pushed
the
pgguru/duckdb-1.4.1
branch
from
9bb5f86 to
ae3e951
Compare
sfc-gh-dachristensen
force-pushed
the
pgguru/duckdb-1.4.1
branch
from
ae3e951 to
153c4c6
Compare
Collaborator
|
probably worth adding a test with: #18 |
Collaborator
|
should we add a test with the example here: #18 Mostly to make sure DuckDB does not regress on this, if does we can warn them. |
Collaborator
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.