Per response code via upstream #2
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-igadot
approved these changes
Sep 2, 2025
| COUNTER(downstream_rq_tx_reset) \ | ||
| COUNTER(downstream_rq_max_duration_reached) \ | ||
| COUNTER(downstream_rq_ws_on_non_ws_route) \ | ||
| COUNTER(via_upstream_downstream_rq_1xx) \ |
Collaborator
There was a problem hiding this comment.
nit: I think downstream_rq_via_upstream is more intuitive.
Collaborator
Author
There was a problem hiding this comment.
True, it was my first preference too. The advantage of ending the name with downstream_rq is that the tag extractor can use the existing regexes here so we do not need to add a new one for matching via_upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]