wayland-protocols: upstream COPYING file no longer included in published crates

[decathorpe]

In PR #828 , the files included in published crates were significantly trimmed down. Apparently it was missed that the COPYING file actually should still be included - the MIT license requires that the original license text is included in redistributed sources:

The above copyright notice and this permission notice (including the next
paragraph) shall be included in all copies or substantial portions of the
Software.

TL;DR: Please re-include protocols/COPYING in published crates.

[ids1024]

the files included in published crates were significantly trimmed down

Only the wayland-protocols crate, to be precise. That PR doesn't affect any other crates.

We only include the protocol .xml files from upstream wayland-protocols, and each of those files has a <copyright> block with a full copyright notice. So I think we're fine here to not include the COPYING file from the root of the repository?

(And it's normal to copy wayland protocol XML files like this, instead of having the whole repository.)

[decathorpe]

The above copyright notice and this permission notice (including the next
paragraph) shall be included in all copies or substantial portions of the
Software.

wayland-protocols is (mostly) a collection of those XML protocol definitions, so you're definitely distributing a "substantial portion" of the software. I don't see how this is controversial?

[ids1024]

And if you look at a file like https://gitlab.freedesktop.org/wayland/wayland-protocols/-/blob/main/stable/linux-dmabuf/linux-dmabuf-v1.xml?ref_type=heads, you'll also see a copy of the MIT license. In the <copyright> section.

[decathorpe]

You're right, (almost) XML files contain individual license texts and copyright statements. When I looked at other Rust crates that shipped Wayland extensions, this was not always the case.

But it's not actually all of them here either - the unstable/pointer-gestures/pointer-gestures-unstable-v1.xml file doesn't contain its own copyright statement and license text, so by default it's covered by the COPYING text (that's currentöy missing).

[ids1024]

Good catch. Presumably upstream wayland-protocols would like to fix that; and might benefit from some kind of CI check that would notice the <copyright> section being missing.

[ids1024]

And we can include the COPYING file too, really. It doesn't take up much space.

But as far as I can tell, the intent upstream is that these files should have the necessary copyright information already.

[decathorpe]

Ok - so would you prefer that the missing <copyright> tag in that protocol is raised with wayland-protocols upstream, which can then be incorporated in wayland-rs?