Set Up Vector for Effects

[Gamingtoday093]

Effects currently use Quaternion.LookRotation(Direction, Vector3.up); to set their orientation, which limits the possible directions an effect can point since the upwards direction is always Vector3.up. I suggest adding the ability to specify the upwards direction to make an effect have any orientation.

https://github.com/Unturned-Datamining/Unturned-Datamining/blob/linux-preview/Assembly-CSharp/SDG.Unturned/EffectManager.cs#L1268

[GazziFX]

I think its better to convert it to euler angles

[GazziFX]

Euler angles is also just a Vector3 but instead of direction it gives a much reliable result and also Quaternion.LookRotation(Vector3.zero) gives warning.
Sending two Vector3 for direction and upwards is overhead

[GazziFX]

You also dealing with euler angles in Unity Editor why you need something else?
You can safely convert direction to angles but you can't get exact angles if you converted it to direction

[Gamingtoday093]

Its way easier to just specify the direction using Vectors instead of having the convert them to Euler Angles.

You can safely convert direction to angles but you can't get exact angles if you converted it to direction

Wdym?

[GazziFX]

Wdym?

You can't define rotation around direction axis

[Gamingtoday093]

Yes you can, you just have to specify what the Upwards direction is which is literally the basis of this Suggestion.

I agree that adding another Vector would result in overhead though. As long as the TriggerEffectParameters get helpers for all the ways youd want to orient an effect like Nelson proposed it will be fine.