-
Notifications
You must be signed in to change notification settings - Fork 0
move git command into server extension #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
this requires a significant design decision. I see multiple options: Smart frontend, dumb backendthe serverside-extention is just a wrapper around elemental git functions (or maybe not even that, maybe it just forwards all parameters to git without any parsing at all) this is the current state dumb frontend, smart backendthe frontend extensions just displays, what the serverside extension needs. maybe the html is even generated on the server. the frontend extension could just look like this:
pro:
con:
neutral:
hybrideach command is defined in javascript and has a corresponding endpoint on the server. pro
con:
|
additional option: backend is rest-api for git, frontend is the actual extension. the frontend (JS) would take care of everything else |
ok, this is what will happen:
|
there are already several implementations of rest apis for git. We should think about using one of those for our server extension (maybe this one?). On the other hand I don't like the idea of adding unneeded dependencies, espially from the moloch that is npm. But then again I don't want to keep track of all subtle parameters, that git knows, so it would be nice when some other organisation takes care of it. |
Issue: currently the git-commands are run in the kernel.
Solution: run the git-command in the serverside extension and use REST to communicate with the frontend (kinda like nbdime does)
The text was updated successfully, but these errors were encountered: