Skip to content

Commit 0193be3

Browse files
Merge pull request #657 from SmartBear/SOAPUIOS-583-SSL-tab-disabled
SOAPUIOS-583 Update SSL info on request execution
2 parents 2c0809c + 900b87e commit 0193be3

File tree

1 file changed

+5
-14
lines changed

1 file changed

+5
-14
lines changed

soapui/src/main/java/com/eviware/soapui/impl/wsdl/support/http/HttpClientSupport.java

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
package com.eviware.soapui.impl.wsdl.support.http;
1818

1919
import com.eviware.soapui.SoapUI;
20-
import com.eviware.soapui.SoapUISystemProperties;
2120
import com.eviware.soapui.impl.support.SSLUtils;
2221
import com.eviware.soapui.impl.wsdl.submit.transports.http.ExtendedHttpMethod;
2322
import com.eviware.soapui.impl.wsdl.submit.transports.http.HttpClientRequestTransport;
@@ -31,9 +30,7 @@
3130
import com.eviware.soapui.settings.SSLSettings;
3231
import com.eviware.soapui.support.MessageSupport;
3332
import com.eviware.soapui.support.StringUtils;
34-
import com.smartbear.soapui.core.Logging;
3533
import org.apache.commons.lang.NullArgumentException;
36-
import org.apache.commons.ssl.KeyMaterial;
3734
import org.apache.http.Header;
3835
import org.apache.http.HttpClientConnection;
3936
import org.apache.http.HttpException;
@@ -56,6 +53,7 @@
5653
import org.apache.http.client.config.CookieSpecs;
5754
import org.apache.http.client.config.RequestConfig;
5855
import org.apache.http.client.methods.CloseableHttpResponse;
56+
import org.apache.http.client.methods.HttpRequestWrapper;
5957
import org.apache.http.client.methods.RequestBuilder;
6058
import org.apache.http.client.params.ClientPNames;
6159
import org.apache.http.client.protocol.ClientContext;
@@ -76,9 +74,6 @@
7674
import org.apache.http.conn.UnsupportedSchemeException;
7775
import org.apache.http.conn.params.ConnRoutePNames;
7876
import org.apache.http.conn.routing.HttpRoutePlanner;
79-
import org.apache.http.conn.scheme.PlainSocketFactory;
80-
import org.apache.http.conn.scheme.Scheme;
81-
import org.apache.http.conn.scheme.SchemeRegistry;
8277
import org.apache.http.conn.socket.ConnectionSocketFactory;
8378
import org.apache.http.conn.ssl.SSLConnectionSocketFactory;
8479
import org.apache.http.conn.util.PublicSuffixMatcher;
@@ -88,7 +83,6 @@
8883
import org.apache.http.impl.client.BasicCookieStore;
8984
import org.apache.http.impl.client.CloseableHttpClient;
9085
import org.apache.http.impl.client.CookieSpecRegistries;
91-
import org.apache.http.impl.client.DefaultHttpClient;
9286
import org.apache.http.impl.client.HttpClientBuilder;
9387
import org.apache.http.impl.client.RequestWrapper;
9488
import org.apache.http.impl.conn.DefaultRoutePlanner;
@@ -110,8 +104,6 @@
110104
import org.apache.logging.log4j.LogManager;
111105
import org.apache.logging.log4j.Logger;
112106

113-
import javax.net.ssl.SSLSession;
114-
import java.io.File;
115107
import java.io.IOException;
116108
import java.net.InetAddress;
117109
import java.net.ProxySelector;
@@ -487,8 +479,8 @@ protected HttpResponse doReceiveResponse(final HttpRequest request, final HttpCl
487479

488480
HttpRequest original = request;
489481

490-
if (original instanceof RequestWrapper) {
491-
RequestWrapper w = (RequestWrapper) request;
482+
if (original instanceof HttpRequestWrapper) {
483+
HttpRequestWrapper w = (HttpRequestWrapper) request;
492484
original = w.getOriginal();
493485
}
494486

@@ -524,11 +516,10 @@ protected HttpResponse doReceiveResponse(final HttpRequest request, final HttpCl
524516

525517
} // while intermediate response
526518

527-
/* TODO:
528519
if (original instanceof ExtendedHttpMethod) {
529520
ExtendedHttpMethod extendedHttpMethod = (ExtendedHttpMethod) original;
530-
extendedHttpMethod.afterReadResponse(((SoapUIMultiThreadedHttpConnectionManager.SoapUIBasicPooledConnAdapter) conn).getSSLSession());
531-
}*/
521+
extendedHttpMethod.afterReadResponse(((ManagedHttpClientConnection) conn).getSSLSession());
522+
}
532523

533524
return response;
534525
}

0 commit comments

Comments
 (0)