Skip to content

Commit f1853b7

Browse files
author
jan
committed
more error logging
1 parent 698fb05 commit f1853b7

File tree

2 files changed

+4
-9
lines changed

2 files changed

+4
-9
lines changed

io.sloeber.core/src/io/sloeber/core/managers/WorkAround.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,8 +120,9 @@ static public File MakeBoardsSloeberTxt(File requestedFileToWorkAround) {
120120
FileUtils.write(boardsSloeberTXT, boardsTXT, Charset.defaultCharset());
121121
}
122122
} catch (IOException e) {
123-
// TODO Auto-generated catch block
124-
e.printStackTrace();
123+
Common.log(new Status(IStatus.WARNING, Activator.getId(),
124+
"Failed to apply work arounds to " + requestedFileToWorkAround.toString(), e));
125+
return requestedFileToWorkAround;
125126
}
126127
}
127128
}

io.sloeber.tests/src/io/sloeber/core/RegressionTest.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
import io.sloeber.providers.ESP8266;
2828
import io.sloeber.providers.MCUBoard;
2929

30-
@SuppressWarnings("nls")
30+
@SuppressWarnings({"nls","static-method"})
3131
public class RegressionTest {
3232
private static final boolean reinstall_boards_and_libraries = false;
3333

@@ -64,7 +64,6 @@ public static void installAdditionalBoards() {
6464
* make sure when switching between a board with variant file and without
6565
* the build still succeeds
6666
*/
67-
@SuppressWarnings("static-method")
6867
@Test
6968
public void issue555() {
7069
if (MySystem.getTeensyPlatform().isEmpty()) {
@@ -123,7 +122,6 @@ public void issue555() {
123122
* support void loop{};
124123
* @throws Exception
125124
*/
126-
@SuppressWarnings("static-method")
127125
@Test
128126
public void issue687() throws Exception {
129127
Arduino.installLatestAVRBoards();
@@ -157,7 +155,6 @@ public void issue687() throws Exception {
157155
* support void loop{};
158156
* @throws Exception
159157
*/
160-
@SuppressWarnings("static-method")
161158
@Test
162159
public void issue1047_Board_Names_Can_Be_used_as_Strings() throws Exception {
163160
MCUBoard unoBoard = ESP8266.nodeMCU();
@@ -191,7 +188,6 @@ public void issue1047_Board_Names_Can_Be_used_as_Strings() throws Exception {
191188
* code checks whether these defines are set properly
192189
* @throws Exception
193190
*/
194-
@SuppressWarnings("static-method")
195191
@Test
196192
public void are_jantjes_options_taken_into_account() throws Exception {
197193
Arduino.installLatestAVRBoards();
@@ -234,7 +230,6 @@ public void are_jantjes_options_taken_into_account() throws Exception {
234230
* properly by the ino to cpp parser
235231
* @throws Exception
236232
*/
237-
@SuppressWarnings("static-method")
238233
@Test
239234
public void are_defines_before_includes_taken_into_account() throws Exception {
240235
Arduino.installLatestAVRBoards();
@@ -271,7 +266,6 @@ public void are_defines_before_includes_taken_into_account() throws Exception {
271266
* be handled properly by the ino to cpp parser
272267
* @throws Exception
273268
*/
274-
@SuppressWarnings("static-method")
275269
@Test
276270
public void is_extern_C_taken_into_account() throws Exception {
277271
Arduino.installLatestAVRBoards();

0 commit comments

Comments
 (0)